Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 2391343003: PPC/s390: Remove unnecessary duplication of FunctionKind enums in CompilerHints (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Remove unnecessary duplication of FunctionKind enums in CompilerHints Port 7a82be3d0d7d3f0a3aa2d2dfdbe64f495a93245b Original commit message: The duplicated enum values are only used by the FastNewClosureStub, so inline them there, with the help of one new constant (kFunctionKindShift) in SharedFunctionInfo. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/0c7e1bef40e26aff393142a30bf3111b47858e83 Cr-Commit-Position: refs/heads/master@{#40017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
john.yan
lgtm
4 years, 2 months ago (2016-10-05 22:42:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391343003/1
4 years, 2 months ago (2016-10-05 22:44:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 23:11:57 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:12:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c7e1bef40e26aff393142a30bf3111b47858e83
Cr-Commit-Position: refs/heads/master@{#40017}

Powered by Google App Engine
This is Rietveld 408576698