Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 239133002: Refactoring: HashMap: provide a pointer match function, so users don't need to. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Refactoring: HashMap: provide a pointer match function, so users don't need to. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20773

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -34 lines) Patch
M src/allocation-tracker.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/debug.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/hashmap.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/serialize.h View 3 chunks +1 line, -7 lines 0 comments Download
M src/serialize.cc View 1 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
yangguo, ptal
6 years, 8 months ago (2014-04-15 13:22:43 UTC) #1
marja
yangguo, ptal
6 years, 8 months ago (2014-04-15 13:23:07 UTC) #2
Yang
On 2014/04/15 13:23:07, marja wrote: > yangguo, ptal lgtm.
6 years, 8 months ago (2014-04-15 13:36:44 UTC) #3
marja
6 years, 8 months ago (2014-04-15 14:48:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698