[inspector] command line api debug and monitor works with bound functions

[inspector] command line api debug and monitor works with bound functions

BUG=chromium:496666
R=dgozman@chromium.org

Committed: https://crrev.com/5ff4d02da5a5c0ede45354a858c6e72b78352393
Cr-Commit-Position: refs/heads/master@{#40007}

[kozy, 2016-10-05 16:18:00]

Dmitry, please take a look!

[dgozman, 2016-10-05 17:23:32]

lgtm

https://codereview.chromium.org/2391323002/diff/1/src/inspector/v8-console.cc
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2391323002/diff/1/src/inspector/v8-console.cc...
src/inspector/v8-console.cc:144: while (targetFunction->IsFunction()) {
while (func->GetBoundFunction()->IsFunction())
  func = func->GetBoundFunction();

https://codereview.chromium.org/2391323002/diff/1/test/inspector/debugger/com...
File test/inspector/debugger/command-line-api-with-bound-function-expected.txt
(right):

https://codereview.chromium.org/2391323002/diff/1/test/inspector/debugger/com...
test/inspector/debugger/command-line-api-with-bound-function-expected.txt:2:
paused in foo
I'd add some console.logs in between so that it's easier to read the test. E.g.

monitor(bar)
debug(bar)
bar()
  > paused in foo
  > function foo called
undebug(foo)

[kozy, 2016-10-05 17:33:10]

Thanks! All done.

https://codereview.chromium.org/2391323002/diff/1/src/inspector/v8-console.cc
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2391323002/diff/1/src/inspector/v8-console.cc...
src/inspector/v8-console.cc:144: while (targetFunction->IsFunction()) {
On 2016/10/05 17:23:32, dgozman wrote:
> while (func->GetBoundFunction()->IsFunction())
>   func = func->GetBoundFunction();

Done.

https://codereview.chromium.org/2391323002/diff/1/test/inspector/debugger/com...
File test/inspector/debugger/command-line-api-with-bound-function-expected.txt
(right):

https://codereview.chromium.org/2391323002/diff/1/test/inspector/debugger/com...
test/inspector/debugger/command-line-api-with-bound-function-expected.txt:2:
paused in foo
On 2016/10/05 17:23:32, dgozman wrote:
> I'd add some console.logs in between so that it's easier to read the test.
E.g.
> 
> monitor(bar)
> debug(bar)
> bar()
>   > paused in foo
>   > function foo called
> undebug(foo)

Done.

[kozy, 2016-10-05 17:33:14]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-05 17:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2391323002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-05 17:33:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:58:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 17:59:17]

Description was changed from

==========
[inspector] command line api debug and monitor works with bound functions

BUG=chromium:496666
R=dgozman@chromium.org
==========

to

==========
[inspector] command line api debug and monitor works with bound functions

BUG=chromium:496666
R=dgozman@chromium.org

Committed: https://crrev.com/5ff4d02da5a5c0ede45354a858c6e72b78352393
Cr-Commit-Position: refs/heads/master@{#40007}
==========

[commit-bot: I haz the power, 2016-10-05 17:59:18]

Patchset 2 (id:??) landed as
https://crrev.com/5ff4d02da5a5c0ede45354a858c6e72b78352393
Cr-Commit-Position: refs/heads/master@{#40007}