Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2391283002: Use FileDescriptorWatcher in SerialIoHandlerPosix. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in SerialIoHandlerPosix. This allows SerialIoHandlerPosix to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/fab0376d55393aabb6811c6cbdbe1f67975b13b4 Cr-Commit-Position: refs/heads/master@{#423883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -52 lines) Patch
M device/serial/serial_io_handler_posix.h View 3 chunks +9 lines, -13 lines 0 comments Download
M device/serial/serial_io_handler_posix.cc View 6 chunks +17 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-05 15:19:05 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-07 15:59:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391283002/1
4 years, 2 months ago (2016-10-07 16:03:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 16:43:30 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:45:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab0376d55393aabb6811c6cbdbe1f67975b13b4
Cr-Commit-Position: refs/heads/master@{#423883}

Powered by Google App Engine
This is Rietveld 408576698