Fix bad-char handling in utf-8 streaming streams. Also add test.

Fix bad-char handling in utf-8 streaming streams. Also add test.

R=jochen@chromium.org
BUG=chromium:651333, v8:4947
Committed: https://crrev.com/138127a60895be2c1d7b6bea9be194d307e5b91e
Cr-Commit-Position: refs/heads/master@{#40004}

[vogelheim, 2016-10-05 14:07:10]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 14:07:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-10-05 15:37:44]

ptal

[jochen (gone - plz use gerrit), 2016-10-05 16:11:56]

lgtm

https://codereview.chromium.org/2391273002/diff/20001/src/parsing/scanner-cha...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2391273002/diff/20001/src/parsing/scanner-cha...
src/parsing/scanner-character-streams.cc:295: DCHECK(t <
unibrow::Utf16::kMaxNonSurrogateCharCode);
DCHECK_LT?

[vogelheim, 2016-10-05 16:22:23]

https://codereview.chromium.org/2391273002/diff/20001/src/parsing/scanner-cha...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2391273002/diff/20001/src/parsing/scanner-cha...
src/parsing/scanner-character-streams.cc:295: DCHECK(t <
unibrow::Utf16::kMaxNonSurrogateCharCode);
On 2016/10/05 16:11:56, jochen (slow) wrote:
> DCHECK_LT?

I tried, but couldn't get that to work. :-(

I think the issue is that kMaxNonSurr... was declared static const so that the
compile can directly use the value, and is not materialized in memory. But the
macro goo that implements DCHECK_LT eventually wants it as a const ..&
parameter. Note the reference. And taking a reference requires that the
parameter occupies memory of some sort.

The error message is:

../../src/parsing/scanner-character-streams.cc:295: error: undefined reference
to 'unibrow::Utf16::kMaxNonSurrogateCharCode'
clang: error: linker command failed with exit code 1 (use -v to see invocation)


Any ideas?

[jochen (gone - plz use gerrit), 2016-10-05 16:50:12]

not really... guess it's ok as is then

[vogelheim, 2016-10-05 16:51:25]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:51:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:18:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 17:19:01]

Description was changed from

==========
Fix bad-char handling in utf-8 streaming streams. Also add test.

R=jochen@chromium.org
BUG=chromium:651333, v8:4947
==========

to

==========
Fix bad-char handling in utf-8 streaming streams. Also add test.

R=jochen@chromium.org
BUG=chromium:651333, v8:4947

Committed: https://crrev.com/138127a60895be2c1d7b6bea9be194d307e5b91e
Cr-Commit-Position: refs/heads/master@{#40004}
==========

[commit-bot: I haz the power, 2016-10-05 17:19:02]

Patchset 2 (id:??) landed as
https://crrev.com/138127a60895be2c1d7b6bea9be194d307e5b91e
Cr-Commit-Position: refs/heads/master@{#40004}