ash/BUILD.gn - Issue 2391253004: Use mojo Shelf interfaces for both mash and classic ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/BUILD.gn

Issue 2391253004: Use mojo Shelf interfaces for both mash and classic ash. (Closed)

Patch Set: Address most comments, except manifest, need to sync. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/BUILD.gn

diff --git a/ash/BUILD.gn b/ash/BUILD.gn

index 80660defaf93a86b6886741fdb354f1e5b491775..a57579a5247ca53148100aa6c1ae0c4adb96072f 100644

--- a/ash/BUILD.gn

+++ b/ash/BUILD.gn

@@ -152,6 +152,8 @@ component("ash") {

"common/shelf/shelf_button_pressed_metric_tracker.h",

"common/shelf/shelf_constants.cc",

"common/shelf/shelf_constants.h",

+ "common/shelf/shelf_controller.cc",

+ "common/shelf/shelf_controller.h",

"common/shelf/shelf_delegate.h",

"common/shelf/shelf_item_delegate.h",

"common/shelf/shelf_item_types.cc",

« no previous file with comments | « no previous file | ash/common/DEPS » ('j') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('J')