views: don't try to throb bookmark buttons

views: don't try to throb bookmark buttons

BookmarkButton does not have a throb animation, so telling it to throb
will cause it to repaint uselessly every 150ms.

BUG=650115

[Elly Fong-Jones, 2016-10-05 16:16:13]

Description was changed from

==========
views: don't try to throb bookmark buttons

BookmarkButton does not have a throb animation, so telling it to throb
will cause it to repaint uselessly every 150ms.

BUG=650115
==========

to

==========
views: don't try to throb bookmark buttons

BookmarkButton does not have a throb animation, so telling it to throb
will cause it to repaint uselessly every 150ms.

BUG=650115
==========

[Elly Fong-Jones, 2016-10-05 16:16:13]

ellyjones@chromium.org changed reviewers:
+ estade@chromium.org

[Elly Fong-Jones, 2016-10-05 16:18:07]

estade: ptal?

This fix is kind of a bandaid. The root issue here is that CustomButton has
throbbing support, but does not define its own throb animation (ie: its
OnPaint() does not pay attention to the throb state), but it *does*
SchedulePaint() in CustomButton::AnimationProgressed(). In theory, any subclass
that cares about animation state when painting should be responsible for
overriding AnimationProgressed() to call SchedulePaint() instead, but that seems
duplicative. Is there a good way for CustomButton to tell whether the subclass
cares about the animation? If not, should we add one?