chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2391253002: Site Settings Desktop: Polish the Site Data section.

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2391253002: Site Settings Desktop: Polish the Site Data section. (Closed)

Patch Set: Address feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/resources/settings/site_settings/site_details.js ('K') | « chrome/browser/ui/webui/options/cookies_view_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 69a418e3638e6a4c1a6d1ae26369c96caadd1933..78fe667918f090499f48b44be2394aa49cd0e1b7 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -1444,15 +1444,28 @@ void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {

{"siteSettingsUsage", IDS_SETTINGS_SITE_SETTINGS_USAGE},

{"siteSettingsPermissions", IDS_SETTINGS_SITE_SETTINGS_PERMISSIONS},

{"siteSettingsClearAndReset", IDS_SETTINGS_SITE_SETTINGS_CLEAR_BUTTON},

- {"siteSettingsDelete", IDS_SETTINGS_SITE_SETTINGS_DELETE},

- {"siteSettingsCookieHeader", IDS_SETTINGS_SITE_SETTINGS_COOKIE_HEADER},

+ {"siteSettingsCookie", IDS_SETTINGS_SITE_SETTINGS_COOKIE},

+ {"siteSettingsCookieClearAll", IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE},

dschuyler 2016/10/07 21:14:49 nit: IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE and

Finnur 2016/10/10 09:56:55 Done.

{"siteSettingsCookieDialog", IDS_SETTINGS_SITE_SETTINGS_COOKIE_DIALOG},

+ {"siteSettingsCookieHeader", IDS_SETTINGS_SITE_SETTINGS_COOKIE_HEADER},

{"siteSettingsCookieRemove", IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE},

{"siteSettingsCookieRemoveAll",

IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_ALL},

{"siteSettingsCookieRemoveAllShown",

IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_ALL_SHOWN},

+ {"siteSettingsCookieRemoveConfirmation",

+ IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_CONFIRMATION},

+ {"siteSettingsCookieRemoveDialogTitle",

+ IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_DIALOG_TITLE},

+ {"siteSettingsCookieRemoveMultipleConfirmation",

+ IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_MULTIPLE},

{"siteSettingsCookieSearch", IDS_SETTINGS_SITE_SETTINGS_COOKIE_SEARCH},

+ {"siteSettingsDelete", IDS_SETTINGS_SITE_SETTINGS_DELETE},

+ {"siteSettingsSiteClearAll", IDS_SETTINGS_SITE_SETTINGS_SITE_DELETE},

dschuyler 2016/10/07 21:14:49 Similar note to above. The _DELETE suffix doesn't

Finnur 2016/10/10 09:56:56 Done.

+ {"siteSettingsSiteRemoveConfirmation",

+ IDS_SETTINGS_SITE_SETTINGS_SITE_REMOVE_CONFIRMATION},

+ {"siteSettingsSiteRemoveDialogTitle",

+ IDS_SETTINGS_SITE_SETTINGS_SITE_REMOVE_DIALOG_TITLE},

{"thirdPartyCookie", IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE},

{"thirdPartyCookieSublabel",

IDS_SETTINGS_SITE_SETTINGS_THIRD_PARTY_COOKIE_SUBLABEL},