Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Issue 2391253002: Site Settings Desktop: Polish the Site Data section. (Closed)
Patch Set: Address feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
index 94b9e910704c30695baad828a8fa8ad4deb4c326..398d597f1cbbe24cdf73bddb5d94a5b056bb911c 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
@@ -33,6 +33,13 @@ Polymer({
entries_: Array,
/**
+ * The cookie nodes to show in the dialog.
+ * @type {!Array<CookieDataForDisplay>}
+ * @private
+ */
+ cookieNodes_: Object,
+
+ /**
* The index of the last selected item.
*/
lastSelectedIndex_: Number,
@@ -118,16 +125,10 @@ Polymer({
* @private
*/
populateItem_: function(id, site) {
- // Out with the old...
- var root = this.$.content;
- while (root.lastChild) {
- root.removeChild(root.lastChild);
- }
-
// In with the new...
dschuyler 2016/10/07 21:14:48 Heh, the comment seems lost without the comment ab
Finnur 2016/10/10 09:56:55 Indeed. Removed.
var node = site.fetchNodeById(id, true);
if (node)
- site.addCookieData(root, node);
+ this.cookieNodes_ = site.getCookieData(node);
},
/**
@@ -172,7 +173,7 @@ Polymer({
// of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
// cookie to differentiate them.
if (item.data.type == 'cookie')
- return item.title;
+ return loadTimeData.getStringF('siteSettingsCookie', item.title);
return getCookieDataCategoryText(item.data.type, item.data.totalUsage);
},

Powered by Google App Engine
This is Rietveld 408576698