Site Settings Desktop: Polish the Site Data section.

chrome/browser/resources/settings/site_settings/site_details.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details' show the details (permissions and usage) for a given origin
  * under Site Settings.
  */
 Polymer({
   is: 'site-details',
 
   behaviors: [SiteSettingsBehavior, settings.RouteObserverBehavior],
 
   properties: {
     /**
      * The site that this widget is showing details for.
      * @type {SiteException}
      */
     site: {
       type: Object,
       observer: 'onSiteChanged_',
     },
 
     /**
      * The amount of data stored for the origin.
+     * @private
      */
     storedData_: {
       type: String,
       value: '',
     },
 
     /**
      * The type of storage for the origin.
+     * @private
      */
     storageType_: Number,
+
+    /** @private */
+    confirmationDeleteMsg_: String,
   },
 
   listeners: {
     'usage-deleted': 'onUsageDeleted',
   },
 

[dschuyler, 2016/10/07 21:14:49]

Optional: /** @override */
I don't think it's actually enforced (thus the
optional note), but it may be someday. :)

[Finnur, 2016/10/10 09:56:55]

Done (for all .js files in this CL)

   ready: function() {
     this.ContentSettingsTypes = settings.ContentSettingsTypes;
   },
 
   /**
    * settings.RouteObserverBehavior
    * @param {!settings.Route} route
    * @protected
    */
   currentRouteChanged: function(route) {
     var site = settings.getQueryParameters().get('site');
     if (!site)
       return;
     this.browserProxy.getSiteDetails(site).then(function(siteInfo) {
       this.site = this.expandSiteException(siteInfo);
     }.bind(this));
   },
 
   /**
    * Handler for when the origin changes.
+   * @private
    */
   onSiteChanged_: function() {
     // originForDisplay may be initially undefined if the user follows a direct
     // link (URL) to this page.
     if (this.site.originForDisplay !== undefined) {
       // Using originForDisplay avoids the [*.] prefix that some exceptions use.
       var url = new URL(this.ensureUrlHasScheme(this.site.originForDisplay));
       this.$.usageApi.fetchUsageTotal(url.hostname);
     }
   },
 
+  /** @private */
+  onCloseDialog_: function() {
+    this.$.confirmDeleteDialog.close();
+  },
+
+  /**
+   * Confirms the deletion of storage for a site.
+   * @param {!{model: !{item: CookieDataSummaryItem}}} event
+   * @private
+   */
+  onConfirmClearStorage_: function(event) {

[dschuyler, 2016/10/07 21:14:49]

Optional: it seems common to leave off the
parameter when it's not referenced in the
function. I don't think it's in the style 
guide, so I'm just throwing it out there as
an option (and the on.*_ functions above and
below this don't have event parameters).

[Finnur, 2016/10/10 09:56:55]

Removed.

+    this.confirmationDeleteMsg_ = loadTimeData.getStringF(
+        'siteSettingsSiteRemoveConfirmation',
+        this.toUrl(this.site.origin).href);
+    this.$.confirmDeleteDialog.showModal();
+  },
+
   /**
    * Clears all data stored for the current origin.
+   * @private
    */
   onClearStorage_: function() {
     this.$.usageApi.clearUsage(
         this.toUrl(this.site.origin).href, this.storageType_);
   },
 
   /**
    * Called when usage has been deleted for an origin.
+   * @private

[dschuyler, 2016/10/07 21:14:49]

@param ... event

and:
Should the function have a trailing underscore
'onUsageDeleted_' or should the @private be removed?

[Finnur, 2016/10/10 09:56:55]

Added @param and trailing underscore.

    */
   onUsageDeleted: function(event) {
     if (event.detail.origin == this.toUrl(this.site.origin).href) {
       this.storedData_ = '';
       this.navigateBackIfNoData_();
     }
   },
 
   /**
    * Resets all permissions and clears all data stored for the current origin.
+   * @private
    */
   onClearAndReset_: function() {
     Array.prototype.forEach.call(
         this.root.querySelectorAll('site-details-permission'),
         function(element) { element.resetPermission(); });
 
     if (this.storedData_ != '')
       this.onClearStorage_();
     else
       this.navigateBackIfNoData_();
   },
 
   /**
    * Navigate back if the UI is empty (everything been cleared).
+   * @private
    */
   navigateBackIfNoData_: function() {
     if (this.storedData_ == '' && !this.permissionShowing_())
       settings.navigateToPreviousRoute();
   },
 
   /**
    * Returns true if one or more permission is showing.
+   * @private
    */
   permissionShowing_: function() {
     return Array.prototype.some.call(
         this.root.querySelectorAll('site-details-permission'),
         function(element) { return element.offsetHeight > 0; });
   },
 });