Site Settings Desktop: Polish the Site Data section.

chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-data-details-dialog' provides a dialog to show details of site data
  * stored by a given site.
  */
 Polymer({
@@ skipping 15 matching lines @@
     site_: Object,
 
     /**
      * The cookie entries for the given site.
      * @type {!Array<!CookieDataItem>}
      * @private
      */
     entries_: Array,
 
     /**
+     * The cookie nodes to show in the dialog.
+     * @type {!Array<CookieDataForDisplay>}
+     * @private
+     */
+    cookieNodes_: Object,
+
+    /**
      * The index of the last selected item.
      */
      lastSelectedIndex_: Number,
 
      /**
       * Our WebUI listener.
       * @type {?WebUIListener}
       */
      listener_: Object,
   },
@@ skipping 65 matching lines @@
     return '';
   },
 
   /**
    * Add the cookie data to the content section of this dialog.
    * @param {string} id The id of the cookie node to display.
    * @param {!settings.CookieTreeNode} site The current site.
    * @private
    */
   populateItem_: function(id, site) {
-    // Out with the old...
-    var root = this.$.content;
-    while (root.lastChild) {
-      root.removeChild(root.lastChild);
-    }
-
     // In with the new...

[dschuyler, 2016/10/07 21:14:48]

Heh, the comment seems lost without the
comment above. Maybe remove it. 

[Finnur, 2016/10/10 09:56:55]

Indeed. Removed.

     var node = site.fetchNodeById(id, true);
     if (node)
-      site.addCookieData(root, node);
+      this.cookieNodes_ = site.getCookieData(node);
   },
 
   /**
    * Called when a single item has been removed.
    * @param {!CookieRemovePacket} args The details about what to remove.
    * @private
    */
   onTreeItemRemoved_: function(args) {
     this.entries_ = this.site_.getCookieList();
     if (this.site_.children_.length == 0 || this.entries_.length == 0) {
@@ skipping 24 matching lines @@
         break;
       }
     }
   },
 
   getEntryDescription: function(item) {
     // Frequently there are multiple cookies per site. To avoid showing a list
     // of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
     // cookie to differentiate them.
     if (item.data.type == 'cookie')
-      return item.title;
+      return loadTimeData.getStringF('siteSettingsCookie', item.title);
 
     return getCookieDataCategoryText(item.data.type, item.data.totalUsage);
   },
 
   /**
    * A handler for when the user opts to remove a single cookie.
    * @private
    */
   onRemove_: function(event) {
     this.browserProxy.removeCookie(this.nodePath_(
         this.site_, this.site_.data_.id, this.$.picker.value));
   },
 
   /**
    * A handler for when the user opts to remove all cookies.
    * @private
    */
   onRemoveAll_: function(event) {
     cr.removeWebUIListener(this.listener_);
     this.browserProxy.removeCookie(this.site_.data_.id);
     this.close();
   },
 
   /** @private */
   onCancelTap_: function() {
     this.$.dialog.cancel();
   },
 });