Site Settings Desktop: Polish the Site Data section.

chrome/browser/resources/settings/site_settings/site_data.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-data' handles showing the local storage summary list for all sites.
  */
 
 Polymer({
   is: 'site-data',
 
   behaviors: [SiteSettingsBehavior, WebUIListenerBehavior],
 
   properties: {
     /**
      * A summary list of all sites and how many entities each contain.
      * @type {Array<CookieDataSummaryItem>}
      */
     sites: Array,
 
     /**
      * The cookie tree with the details needed to display individual sites and
      * their contained data.
      * @type {!settings.CookieTreeNode}
+     * @private
      */
     treeNodes_: Object,
 
     /**
      * Keeps track of how many outstanding requests for more data there are.
+     * @private
      */
     requests_: Number,
 
     /**
      * The current filter applied to the cookie data list.
+     * @private
      */
     filterString_: {
       type: String,
       value: '',
-    }
+    },
+
+    /** @private */
+    confirmationDeleteMsg_: String,
+
+    /** @private */
+    idToDelete_: String,
   },
 
   ready: function() {
     this.addWebUIListener('onTreeItemRemoved',
         this.onTreeItemRemoved_.bind(this));
     this.treeNodes_ = new settings.CookieTreeNode(null);
     // Start the initial request.
     this.reloadCookies_();
   },
 
@@ skipping 76 matching lines @@
 
     // If this reaches below zero then we're forgetting to increase the
     // outstanding request count and the summary list won't be updated at the
     // end.
     assert(this.requests_ >= 0);
   },
 
   /**
    * Called when a single item has been removed (not during delete all).
    * @param {!CookieRemovePacket} args The details about what to remove.
+   * @private
    */
   onTreeItemRemoved_: function(args) {
     this.treeNodes_.removeByParentId(args.id, args.start, args.count);
     this.sites = this.treeNodes_.getSummaryList();
   },
 
+  /** @private */
+  onCloseDialog_: function() {
+    this.$.confirmDeleteDialog.close();
+  },
+
   /**
-   * Deletes all site data for a given site.
+   * Confirms the deletion of a site.
    * @param {!{model: !{item: CookieDataSummaryItem}}} event
    * @private
    */
-  onDeleteSite_: function(event) {
-    this.browserProxy.removeCookie(event.model.item.id);
+  onConfirmDeleteSite_: function(event) {
+    this.idToDelete_ = event.model.item.id;
+    this.confirmationDeleteMsg_ = loadTimeData.getStringF(
+        'siteSettingsCookieRemoveConfirmation', event.model.item.site);
+    this.$.confirmDeleteDialog.showModal();
+  },
+

[dschuyler, 2016/10/07 21:14:48]

@param ... event (Or remove the parameter)
@private 

[Finnur, 2016/10/10 09:56:55]

Removed.

+  onConfirmDeleteMultipleSites_: function(event) {
+    this.idToDelete_ = '';  // Delete all.
+    this.confirmationDeleteMsg_ = loadTimeData.getString(
+        'siteSettingsCookieRemoveMultipleConfirmation');
+    this.$.confirmDeleteDialog.showModal();
+  },
+

[dschuyler, 2016/10/07 21:14:48]

@param ... event (Or remove the parameter)
@private 

[Finnur, 2016/10/10 09:56:55]

Removed.

+  onConfirmDelete_: function(event) {
+    if (this.idToDelete_ != '')
+      this.onDeleteSite_();
+    else
+      this.onDeleteMultipleSites_();
+    this.$.confirmDeleteDialog.close();
   },
 
   /**
+   * Deletes all site data for a given site.
+   * @private
+   */
+  onDeleteSite_: function() {
+    this.browserProxy.removeCookie(this.idToDelete_);
+  },
+
+  /**
    * Deletes site data for multiple sites.
    * @private
    */
   onDeleteMultipleSites_: function() {
     if (this.filterString_.length == 0) {
       this.browserProxy.removeAllCookies().then(function(list) {
         this.loadChildren_(list);
       }.bind(this));
     } else {
       var items = this.$.list.items;
@@ skipping 14 matching lines @@
     this.shadowRoot.appendChild(dialog);
 
     var node = this.treeNodes_.fetchNodeById(event.model.item.id, false);
     dialog.open(node);
 
     dialog.addEventListener('close', function(event) {
       dialog.remove();
     });
   },
 });