|
|
Chromium Code Reviews
Descriptionclean up message "External extension with id xxxx has been uninstalled by ..."
The same messages get logged repeatedly. Is this really warning?
If this can happen in normal condition, please change to VLOG or DLOG.
BUG=496860
Committed: https://crrev.com/adae398e9702324fb605c4bb0969c352363cadee
Cr-Commit-Position: refs/heads/master@{#423939}
Patch Set 1 #
Total comments: 1
Patch Set 2 : clean up message "External extension with id xxxx has been uninstalled by ..." #Messages
Total messages: 19 (10 generated)
Description was changed from ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 ========== to ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 ==========
peary2@gmail.com changed reviewers: + benwells@chromium.org, oshima@chromium.org, rdevlin.cronin@chromium.org
peary2@gmail.com changed reviewers: + rockot@chromium.org
PTAL :)
peary2@gmail.com changed reviewers: + sky@chromium.org
peary2@gmail.com changed reviewers: - sky@chromium.org
rockot@chromium.org changed reviewers: + asargent@chromium.org
-rockot +asargent This is probably good, but maybe you want something other than DLOG (like VLOG(1) or for example). I'll let asargent@ decide!
rockot@chromium.org changed reviewers: - rockot@chromium.org
looks like there's plenty of reviewers on this already; me -> cc
https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extensio... File extensions/browser/extension_prefs.cc (right): https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extensio... extensions/browser/extension_prefs.cc:1263: << " has been uninstalled by the user"; I think it's safe to just remove this; as far as I know it has either rarely or never been helpful in tracking down actual problems.
On 2016/10/05 18:05:01, Antony Sargent wrote: > https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extensio... > File extensions/browser/extension_prefs.cc (right): > > https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extensio... > extensions/browser/extension_prefs.cc:1263: << " has been uninstalled by the > user"; > I think it's safe to just remove this; as far as I know it has either rarely or > never been helpful in tracking down actual problems. I update patch set for delete log. Could you run build bot & reviews? :)
The CQ bit was checked by asargent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 ========== to ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 ========== to ========== clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 Committed: https://crrev.com/adae398e9702324fb605c4bb0969c352363cadee Cr-Commit-Position: refs/heads/master@{#423939} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/adae398e9702324fb605c4bb0969c352363cadee Cr-Commit-Position: refs/heads/master@{#423939} |
