Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2391243002: clean up message "External extension with id xxxx has been uninstalled by ..." (Closed)

Created:
4 years, 2 months ago by Yeol Park
Modified:
4 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, Devlin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean up message "External extension with id xxxx has been uninstalled by ..." The same messages get logged repeatedly. Is this really warning? If this can happen in normal condition, please change to VLOG or DLOG. BUG=496860 Committed: https://crrev.com/adae398e9702324fb605c4bb0969c352363cadee Cr-Commit-Position: refs/heads/master@{#423939}

Patch Set 1 #

Total comments: 1

Patch Set 2 : clean up message "External extension with id xxxx has been uninstalled by ..." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M extensions/browser/extension_prefs.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Yeol Park
PTAL :)
4 years, 2 months ago (2016-10-05 09:43:17 UTC) #4
Ken Rockot(use gerrit already)
-rockot +asargent This is probably good, but maybe you want something other than DLOG (like ...
4 years, 2 months ago (2016-10-05 14:09:18 UTC) #8
Devlin
looks like there's plenty of reviewers on this already; me -> cc
4 years, 2 months ago (2016-10-05 16:44:54 UTC) #10
asargent_no_longer_on_chrome
https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extension_prefs.cc File extensions/browser/extension_prefs.cc (right): https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extension_prefs.cc#newcode1263 extensions/browser/extension_prefs.cc:1263: << " has been uninstalled by the user"; I ...
4 years, 2 months ago (2016-10-05 18:05:01 UTC) #11
Yeol Park
On 2016/10/05 18:05:01, Antony Sargent wrote: > https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extension_prefs.cc > File extensions/browser/extension_prefs.cc (right): > > https://codereview.chromium.org/2391243002/diff/1/extensions/browser/extension_prefs.cc#newcode1263 ...
4 years, 2 months ago (2016-10-06 02:37:22 UTC) #12
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-07 18:59:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391243002/20001
4 years, 2 months ago (2016-10-07 18:59:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 19:45:11 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:46:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/adae398e9702324fb605c4bb0969c352363cadee
Cr-Commit-Position: refs/heads/master@{#423939}

Powered by Google App Engine
This is Rietveld 408576698