Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2391223002: Revert of [wasm] Call a runtime function for a MemorySize instruction. (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Call a runtime function for a MemorySize instruction. (patchset #2 id:20001 of https://codereview.chromium.org/2386183004/ ) Reason for revert: Patch problem Original issue's description: > [wasm] Call a runtime function for a MemorySize instruction. > > The implementation of MemorySize with RelocatableInt32Constants is > problematic if MemorySize is placed close to a GrowMemory instruction in > the code. The use of a runtime function guarantees that the order in > which MemorySize and GrowMemory is executed is correct. > > R=titzer@chromium.org > BUG=chromium:651961 > TEST=mjsunit/regress/wasm/regression-651961 > > Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689 > Cr-Commit-Position: refs/heads/master@{#39972} TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651961 Committed: https://crrev.com/9701e79127c75a41d870745192dd1b63c6cbc63b Cr-Commit-Position: refs/heads/master@{#39973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -92 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +2 lines, -21 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-wasm.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D test/mjsunit/regress/wasm/regression-651961.js View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahaas
Created Revert of [wasm] Call a runtime function for a MemorySize instruction.
4 years, 2 months ago (2016-10-05 06:11:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391223002/1
4 years, 2 months ago (2016-10-05 06:11:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 06:12:07 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:12:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9701e79127c75a41d870745192dd1b63c6cbc63b
Cr-Commit-Position: refs/heads/master@{#39973}

Powered by Google App Engine
This is Rietveld 408576698