tools/run-perf.sh - Issue 2391193003: [tools] run-perf: ensure command line arguments are prepended

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run-perf.sh

Issue 2391193003: [tools] run-perf: ensure command line arguments are prepended (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/run-perf.sh

diff --git a/tools/run-perf.sh b/tools/run-perf.sh

index 03123fdbb84df8829854eb07978605cc09bb7f7d..880f126a4a62d50e4aaabcfc33e827b756b50113 100755

--- a/tools/run-perf.sh

+++ b/tools/run-perf.sh

@@ -45,9 +45,14 @@ if [ "$ACTUAL_KERNEL_MAP_RESTRICTION" -ne "0" ] ; then

echo 0 | sudo tee $KERNEL_MAP_CONFIG_FILE

+# Extract the command being perfed, so that we can prepend arguments to the

+# arguments that the user supplied.

+COMMAND=$1

+shift 1

echo "Running..."

perf record -R \

-e $EVENT_TYPE \

-c $SAMPLE_EVERY_N_CYCLES \

--call-graph $CALL_GRAPH_METHOD \

- -i $@ --perf_basic_prof

+ -i $1 --perf_basic_prof "$@"

rmcilroy 2016/10/05 11:26:49 Should the $1 here be $COMMAND instead?

Leszek Swirski 2016/10/05 11:29:41 It absolutely should, not sure how that snuck past

« no previous file with comments | « no previous file | no next file » | no next file with comments »