[tools] run-perf: ensure command line arguments are prepended

[tools] run-perf: ensure command line arguments are prepended

This change to run-perf.sh ensures that command line arguments are
prepended rather than appended to the passed in command. This is to
ensure that the arguments to d8 aren't accidentally passed through to
the js instead, as would be in the case:

tools/run-perf.sh d8 main.js -- --js-arg

A real-life example is passing --predictable to Octane's run.js

Committed: https://crrev.com/fdc277e645c9ce7cec2ab65d117a7f14cd70f17d
Cr-Commit-Position: refs/heads/master@{#39999}

[Leszek Swirski, 2016-10-05 11:13:33]

leszeks@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Leszek Swirski, 2016-10-05 11:13:33]

Small change to fix how run-perf works when running Octane

[rmcilroy, 2016-10-05 11:26:49]

https://codereview.chromium.org/2391193003/diff/1/tools/run-perf.sh
File tools/run-perf.sh (right):

https://codereview.chromium.org/2391193003/diff/1/tools/run-perf.sh#newcode58
tools/run-perf.sh:58: -i $1 --perf_basic_prof "$@"
Should the $1 here be $COMMAND instead?

[Leszek Swirski, 2016-10-05 11:29:41]

https://codereview.chromium.org/2391193003/diff/1/tools/run-perf.sh
File tools/run-perf.sh (right):

https://codereview.chromium.org/2391193003/diff/1/tools/run-perf.sh#newcode58
tools/run-perf.sh:58: -i $1 --perf_basic_prof "$@"
On 2016/10/05 11:26:49, rmcilroy wrote:
> Should the $1 here be $COMMAND instead?

It absolutely should, not sure how that snuck past me / ever worked at all.
Done.

[rmcilroy, 2016-10-05 14:43:34]

LGTM.

[Leszek Swirski, 2016-10-05 14:47:45]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 15:15:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 15:15:46]

Description was changed from

==========
[tools] run-perf: ensure command line arguments are prepended

This change to run-perf.sh ensures that command line arguments are
prepended rather than appended to the passed in command. This is to
ensure that the arguments to d8 aren't accidentally passed through to
the js instead, as would be in the case:

tools/run-perf.sh d8 main.js -- --js-arg

A real-life example is passing --predictable to Octane's run.js
==========

to

==========
[tools] run-perf: ensure command line arguments are prepended

This change to run-perf.sh ensures that command line arguments are
prepended rather than appended to the passed in command. This is to
ensure that the arguments to d8 aren't accidentally passed through to
the js instead, as would be in the case:

tools/run-perf.sh d8 main.js -- --js-arg

A real-life example is passing --predictable to Octane's run.js

Committed: https://crrev.com/fdc277e645c9ce7cec2ab65d117a7f14cd70f17d
Cr-Commit-Position: refs/heads/master@{#39999}
==========

[commit-bot: I haz the power, 2016-10-05 15:15:47]

Patchset 2 (id:??) landed as
https://crrev.com/fdc277e645c9ce7cec2ab65d117a7f14cd70f17d
Cr-Commit-Position: refs/heads/master@{#39999}