Issue 2391173003: Catch and suppress expected exceptions in corrections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2391173003: Catch and suppress expected exceptions in corrections. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Catch and suppress expected exceptions in corrections. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f69311914618d46136cdc81709470c6eb6d2f66a

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -13 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	3 chunks	+25 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2391173003/diff/1/pkg/analysis_server/lib/src/services/correction/util.dart File pkg/analysis_server/lib/src/services/correction/util.dart (right): https://codereview.chromium.org/2391173003/diff/1/pkg/analysis_server/lib/src/services/correction/util.dart#newcode710 pkg/analysis_server/lib/src/services/correction/util.dart:710: throw new CancelCorrectionException(); How often does this occur? ...

4 years, 2 months ago (2016-10-05 13:52:20 UTC) #2

scheglov

4 years, 2 months ago (2016-10-05 15:31:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f69311914618d46136cdc81709470c6eb6d2f66a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages