Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2391163002: [android] Support not passing --adb-path. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
Reviewers:
bpastene, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[android] Support not passing --adb-path. This is a workaround for the perf bots, which currently are using chromium's adb because of this in the perf test runner while using devil's adb while running benchmarks. This should be backed out once telemetry supports configurable adb paths. BUG=652250 Committed: https://chromium.googlesource.com/chromium/tools/build/+/6b5d14dc03df1b90ff9794d0887a491b2c7bad6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
I intend to use this in android/perf, which has already moved to chromium.
4 years, 2 months ago (2016-10-04 23:46:10 UTC) #2
martiniss
lgtm
4 years, 2 months ago (2016-10-04 23:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391163002/1
4 years, 2 months ago (2016-10-04 23:50:21 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:58:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6b5d14dc03df1b90ff97...

Powered by Google App Engine
This is Rietveld 408576698