Converts most of WorkspaceLayoutManager tests to use common code

ash/common/wm_window.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_WM_WINDOW_H_
 #define ASH_COMMON_WM_WINDOW_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 76 matching lines @@
   virtual void SetShellWindowId(int id) = 0;
   virtual int GetShellWindowId() const = 0;
   virtual WmWindow* GetChildByShellWindowId(int id) = 0;
 
   virtual ui::wm::WindowType GetType() const = 0;
   virtual int GetAppType() const = 0;
   virtual void SetAppType(int app_type) const = 0;
 
   virtual bool IsBubble() = 0;
 
-  // TODO(sky): seems like this shouldn't be exposed.
   virtual ui::Layer* GetLayer() = 0;
 
+  // TODO(sky): these are temporary until GetLayer() always returns non-null.
+  virtual bool GetLayerTargetVisibility() = 0;
+  virtual bool GetLayerVisible() = 0;
+
   virtual display::Display GetDisplayNearestWindow() = 0;
 
   virtual bool HasNonClientArea() = 0;
   virtual int GetNonClientComponent(const gfx::Point& location) = 0;
 
   virtual gfx::Point ConvertPointToTarget(const WmWindow* target,
                                           const gfx::Point& point) const = 0;
   virtual gfx::Point ConvertPointToScreen(const gfx::Point& point) const = 0;
   virtual gfx::Point ConvertPointFromScreen(const gfx::Point& point) const = 0;
   virtual gfx::Rect ConvertRectToScreen(const gfx::Rect& rect) const = 0;
@@ skipping 121 matching lines @@
   // of the bounds set on it.
   virtual void SetLockedToRoot(bool value) = 0;
   virtual bool IsLockedToRoot() const = 0;
 
   virtual void SetCapture() = 0;
   virtual bool HasCapture() = 0;
   virtual void ReleaseCapture() = 0;
 
   virtual bool HasRestoreBounds() const = 0;
 
+  // See ScreenPinningController::SetPinnedWindow() for details.

[msw, 2016/10/06 20:18:24]

aside: The comment there is: "Sets a pinned window. It is not allowed to call
this when there already is a pinned window." Something should actually explain
what it means for a window to be pinned. Maybe reference wm::PinWindow(), which
gives a better explanation: "Pins the window on top of other windows." (ie.
always-on-top [local to some container?])

[sky, 2016/10/06 21:05:58]

I completely agree with on the lack of documentation for pinning, but I tend to
think that is out of scope of this patch (ScreenPinningController should be the
one describing all this). Even pins on top of other windows doesn't really
describe it in detail.

[msw, 2016/10/06 21:19:16]

Acknowledged.

+  virtual void SetPinned(bool trusted) = 0;
+
   virtual void SetAlwaysOnTop(bool value) = 0;
   virtual bool IsAlwaysOnTop() const = 0;
 
   virtual void Hide() = 0;
   virtual void Show() = 0;
 
   // Returns the widget associated with this window, or null if not associated
   // with a widget. Only ash system UI widgets are returned, not widgets created
   // by the mus window manager code to show a non-client frame.
   virtual views::Widget* GetInternalWidget() = 0;
@@ skipping 73 matching lines @@
   virtual void AddLimitedPreTargetHandler(ui::EventHandler* handler) = 0;
   virtual void RemoveLimitedPreTargetHandler(ui::EventHandler* handler) = 0;
 
  protected:
   virtual ~WmWindow() {}
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_WM_WINDOW_H_