remove sprintf

remove sprintf

Most uses of sprintf are
in pathops testing.

Replace them with
SkString::appendf

and replace the remaining
with snprintf

R=scroggo@google.com
BUG=skia:2716
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133005

Committed: https://skia.googlesource.com/skia/+/8f1864386734cfa7650a5576ba453745a407ade2

[caryclark, 2016-10-06 14:08:46]

Description was changed from

==========
remove sprintf

Most uses of sprintf are
in pathops testing.

Replace them with
SkString::appendf

and replace the remaining
with snprintf

R=scroggo@google.com
BUG=skia:2716
==========

to

==========
remove sprintf

Most uses of sprintf are
in pathops testing.

Replace them with
SkString::appendf

and replace the remaining
with snprintf

R=scroggo@google.com
BUG=skia:2716
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133005
==========

[caryclark, 2016-10-06 14:09:08]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 14:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 14:26:46]

Dry run: This issue passed the CQ dry run.

[scroggo, 2016-10-06 14:42:00]

lgtm

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpCircleThread...
File tests/PathOpsOpCircleThreadedTest.cpp (right):

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpCircleThread...
tests/PathOpsOpCircleThreadedTest.cpp:11: static int loopNo = 4;
nit: I think this should be gLoopNo, since it's a global.

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpLoopThreaded...
File tests/PathOpsOpLoopThreadedTest.cpp (right):

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpLoopThreaded...
tests/PathOpsOpLoopThreadedTest.cpp:11: static int loopNo = 17;
nit: gLoopNo

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpRectThreaded...
File tests/PathOpsOpRectThreadedTest.cpp (right):

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsOpRectThreaded...
tests/PathOpsOpRectThreadedTest.cpp:18: static int loopNo = 6;
nit: gLoopNo

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsSimplifyQuadTh...
File tests/PathOpsSimplifyQuadThreadedTest.cpp (right):

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsSimplifyQuadTh...
tests/PathOpsSimplifyQuadThreadedTest.cpp:11: static int quadTest = 66;
nit: gQuadTest

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsSimplifyQuadra...
File tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp (right):

https://codereview.chromium.org/2391133005/diff/1/tests/PathOpsSimplifyQuadra...
tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp:11: static int loopNo = 1;
nit: gLoopNo

[caryclark, 2016-10-06 18:44:57]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-10-06 18:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:46:27]

Description was changed from

==========
remove sprintf

Most uses of sprintf are
in pathops testing.

Replace them with
SkString::appendf

and replace the remaining
with snprintf

R=scroggo@google.com
BUG=skia:2716
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133005
==========

to

==========
remove sprintf

Most uses of sprintf are
in pathops testing.

Replace them with
SkString::appendf

and replace the remaining
with snprintf

R=scroggo@google.com
BUG=skia:2716
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133005

Committed:
https://skia.googlesource.com/skia/+/8f1864386734cfa7650a5576ba453745a407ade2
==========

[commit-bot: I haz the power, 2016-10-06 18:46:28]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8f1864386734cfa7650a5576ba453745a407ade2