Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2391133004: Reduce geometry size for circles to help fill rate. (Closed)

Created:
4 years, 2 months ago by jvanverth1
Modified:
4 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reduce geometry size for circles to help fill rate. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133004 Committed: https://skia.googlesource.com/skia/+/6ca48820407244bbdeb8f9e0ed7d76dd94270460

Patch Set 1 #

Patch Set 2 : Fixes to get matching GMs #

Patch Set 3 : Got basic octagon working #

Patch Set 4 : Chop out center of stroked circles #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -31 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 2 3 17 chunks +270 lines, -31 lines 3 comments Download

Messages

Total messages: 14 (8 generated)
jvanverth1
This does appear to run a little faster on Android, as far as one can ...
4 years, 2 months ago (2016-10-06 19:29:40 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp#newcode968 src/gpu/GrOvalRenderer.cpp:968: if (geom.fStroked) { Could this path share a ...
4 years, 2 months ago (2016-10-06 20:09:56 UTC) #4
jvanverth1
https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp#newcode968 src/gpu/GrOvalRenderer.cpp:968: if (geom.fStroked) { On 2016/10/06 20:09:56, robertphillips wrote: > ...
4 years, 2 months ago (2016-10-06 21:46:19 UTC) #9
robertphillips
https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2391133004/diff/60001/src/gpu/GrOvalRenderer.cpp#newcode968 src/gpu/GrOvalRenderer.cpp:968: if (geom.fStroked) { On 2016/10/06 21:46:19, jvanverth1 wrote: > ...
4 years, 2 months ago (2016-10-06 21:51:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391133004/60001
4 years, 2 months ago (2016-10-07 13:56:40 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 13:57:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ca48820407244bbdeb8f9e0ed7d76dd94270460

Powered by Google App Engine
This is Rietveld 408576698