Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239113009: Reland "Move functions from handles.cc to where they belong." (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Reland "Move functions from handles.cc to where they belong." R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20807

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+704 lines, -720 lines) Patch
M src/accessors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/allocation-tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/api.cc View 16 chunks +31 lines, -36 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/debug.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/frames.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/handles.h View 2 chunks +0 lines, -48 lines 0 comments Download
M src/handles.cc View 3 chunks +1 line, -541 lines 0 comments Download
M src/isolate.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/json-stringifier.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/lithium-codegen.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/liveedit.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/log.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 6 chunks +42 lines, -1 line 0 comments Download
M src/objects.cc View 5 chunks +504 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/runtime.cc View 11 chunks +23 lines, -13 lines 0 comments Download
M test/cctest/test-compiler.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
second patch set is the fix.
6 years, 8 months ago (2014-04-16 12:46:11 UTC) #1
Jarin
lgtm
6 years, 8 months ago (2014-04-16 12:50:14 UTC) #2
Yang
On 2014/04/16 12:50:14, jarin wrote: > lgtm fixed some renaming that I forgot about.
6 years, 8 months ago (2014-04-16 12:57:53 UTC) #3
Yang
6 years, 8 months ago (2014-04-16 13:28:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r20807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698