Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 239113007: <webview>: Move pointerLock permission to chrome (Closed)

Created:
6 years, 8 months ago by Fady Samuel
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_downloads_to_chrome
Visibility:
Public.

Description

<webview>: Move pointerLock permission to chrome BUG=330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -53 lines) Patch
M chrome/browser/guestview/guestview_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guestview/guestview_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guestview/webview/webview_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_guest.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_guest.cc View 10 chunks +44 lines, -14 lines 0 comments Download
M chrome/browser/guestview/webview/webview_permission_types.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +14 lines, -29 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +8 lines, -1 line 0 comments Download
M content/public/common/browser_plugin_permission_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 6 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fady Samuel
6 years, 8 months ago (2014-04-15 19:53:44 UTC) #1
lazyboy
lgtm
6 years, 8 months ago (2014-04-15 20:44:46 UTC) #2
Fady Samuel
+jam@ for content/public changes +asvitkine@ for actions.xml
6 years, 8 months ago (2014-04-15 20:45:51 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-15 21:16:15 UTC) #4
lazyboy
SLGTM. Please update the BUG= line.
6 years, 8 months ago (2014-04-15 21:18:25 UTC) #5
jam
lgtm
6 years, 8 months ago (2014-04-15 22:48:10 UTC) #6
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-16 10:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/239113007/1
6 years, 8 months ago (2014-04-16 10:56:48 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 17:18:27 UTC) #9
Message was sent while issue was closed.
Change committed as 264236

Powered by Google App Engine
This is Rietveld 408576698