Issue 239113003: Use the media controls play button internal state for painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239113003: Use the media controls play button internal state for painting (Closed)

Created:
6 years, 8 months ago by philipj_slow

Modified:
6 years, 8 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, zoltan1, dsinclair, philipj_slow, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, bemjb+rendering_chromium.org, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use the media controls play button internal state for painting MediaControlElement::displayType() is not actually used for rendering, the logic is instead duplicated in RenderMediaControls, sometimes with minor differences. When scrubbing was made internal to the controls in r169814, I neglected to update the corresponding rendering code. BUG=359522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171706

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -20 lines)			Patch
A +	LayoutTests/media/controls-drag-timebar-rendering.html	View	2 chunks	+11 lines, -15 lines	0 comments	Download
A +	LayoutTests/media/controls-drag-timebar-rendering-expected-mismatch.html	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderMediaControls.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/239113003/1

6 years, 8 months ago (2014-04-15 21:13:38 UTC) #4

Message was sent while issue was closed.

Change committed as 171706

Expand Messages | Collapse Messages