Issue 239113002: Handlifying clients of StringTable, step 1.

Issue 239113002: Handlifying clients of StringTable, step 1. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handlifying clients of StringTable, step 1. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20772

Patch Set 2 : Addressing review notes #

Created: 6 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -171 lines)
M	src/factory.h	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/factory.cc	View	1 chunk	+10 lines, -0 lines	0 comments
M	src/heap.h	View	2 chunks	+4 lines, -9 lines	0 comments
M	src/heap.cc	View	5 chunks	+86 lines, -136 lines	0 comments
M	src/objects.h	View	1 chunk	+5 lines, -4 lines	0 comments
M	src/objects.cc	View	2 chunks	+14 lines, -14 lines	0 comments
M	src/runtime.cc	View	2 chunks	+8 lines, -8 lines	0 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM! https://codereview.chromium.org/239113002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/239113002/diff/1/src/heap.cc#newcode5951 src/heap.cc:5951: Runtime::InitializeIntrinsicFunctionNames( I guess at some point we want ...

6 years, 8 months ago (2014-04-15 13:31:39 UTC) #2

Igor Sheludko

PTAL https://codereview.chromium.org/239113002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/239113002/diff/1/src/heap.cc#newcode5951 src/heap.cc:5951: Runtime::InitializeIntrinsicFunctionNames( On 2014/04/15 13:31:40, Yang wrote: > I ...

6 years, 8 months ago (2014-04-15 14:00:28 UTC) #3

Igor Sheludko

6 years, 8 months ago (2014-04-15 14:21:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20772 (presubmit successful).

Expand Messages | Collapse Messages