Use void* again for PlatformFence

Use uint64_t for PlatformFence

VkFence is 64 bit even on 32-bit platforms.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002

Committed: https://skia.googlesource.com/skia/+/024229a38d86fc53801092e149d8599b2b2bc9fb

[csmartdalton, 2016-10-04 20:05:48]

Description was changed from

==========
Use void* again for PlatformFence

Looks like sizeof(intptr_t) < sizeof(void*) sometimes.

BUG=skia:
==========

to

==========
Use void* again for PlatformFence

Looks like sizeof(intptr_t) < sizeof(void*) sometimes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002
==========

[csmartdalton, 2016-10-04 20:07:32]

csmartdalton@google.com changed reviewers:
+ djsollen@google.com, stephana@google.com

[djsollen, 2016-10-04 20:19:01]

The CQ bit was checked by djsollen@google.com

[djsollen, 2016-10-04 20:19:01]

lgtm

[commit-bot: I haz the power, 2016-10-04 20:19:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-10-04 20:19:14]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-10-04 20:19:14]

> Looks like sizeof(intptr_t) < sizeof(void*) sometimes.

I don't think that can possibly be true.

[csmartdalton, 2016-10-04 20:21:25]

On 2016/10/04 20:19:14, mtklein wrote:
> > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> 
> I don't think that can possibly be true.

The failing build that was fixed by this change would suggest otherwise.

And the error message shows that intptr_t == int on Derek's platform.

Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*) somewhere to
verify?

[mtklein, 2016-10-04 20:23:17]

On 2016/10/04 20:21:25, csmartdalton wrote:
> On 2016/10/04 20:19:14, mtklein wrote:
> > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > 
> > I don't think that can possibly be true.
> 
> The failing build that was fixed by this change would suggest otherwise.
> 
> And the error message shows that intptr_t == int on Derek's platform.
> 
> Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*) somewhere
to
> verify?

static_assert(sizeof(intptr_t) == sizeof(void*), "");

[mtklein, 2016-10-04 20:23:51]

On 2016/10/04 20:23:17, mtklein wrote:
> On 2016/10/04 20:21:25, csmartdalton wrote:
> > On 2016/10/04 20:19:14, mtklein wrote:
> > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > 
> > > I don't think that can possibly be true.
> > 
> > The failing build that was fixed by this change would suggest otherwise.
> > 
> > And the error message shows that intptr_t == int on Derek's platform.
> > 
> > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
somewhere
> to
> > verify?
> 
> static_assert(sizeof(intptr_t) == sizeof(void*), "");

(intptr_t == int on 32-bit devices)

[csmartdalton, 2016-10-04 20:24:38]

On 2016/10/04 20:23:17, mtklein wrote:
> On 2016/10/04 20:21:25, csmartdalton wrote:
> > On 2016/10/04 20:19:14, mtklein wrote:
> > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > 
> > > I don't think that can possibly be true.
> > 
> > The failing build that was fixed by this change would suggest otherwise.
> > 
> > And the error message shows that intptr_t == int on Derek's platform.
> > 
> > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
somewhere
> to
> > verify?
> 
> static_assert(sizeof(intptr_t) == sizeof(void*), "");

I can't do it locally, this only shows up on the android framework builds, which
I am not set up with.

[mtklein, 2016-10-04 20:25:34]

On 2016/10/04 20:24:38, csmartdalton wrote:
> On 2016/10/04 20:23:17, mtklein wrote:
> > On 2016/10/04 20:21:25, csmartdalton wrote:
> > > On 2016/10/04 20:19:14, mtklein wrote:
> > > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > > 
> > > > I don't think that can possibly be true.
> > > 
> > > The failing build that was fixed by this change would suggest otherwise.
> > > 
> > > And the error message shows that intptr_t == int on Derek's platform.
> > > 
> > > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
> somewhere
> > to
> > > verify?
> > 
> > static_assert(sizeof(intptr_t) == sizeof(void*), "");
> 
> I can't do it locally, this only shows up on the android framework builds,
which
> I am not set up with.

Add that to literally any .cpp file and submit...

[mtklein, 2016-10-04 20:25:35]

On 2016/10/04 20:24:38, csmartdalton wrote:
> On 2016/10/04 20:23:17, mtklein wrote:
> > On 2016/10/04 20:21:25, csmartdalton wrote:
> > > On 2016/10/04 20:19:14, mtklein wrote:
> > > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > > 
> > > > I don't think that can possibly be true.
> > > 
> > > The failing build that was fixed by this change would suggest otherwise.
> > > 
> > > And the error message shows that intptr_t == int on Derek's platform.
> > > 
> > > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
> somewhere
> > to
> > > verify?
> > 
> > static_assert(sizeof(intptr_t) == sizeof(void*), "");
> 
> I can't do it locally, this only shows up on the android framework builds,
which
> I am not set up with.

Add that to literally any .cpp file and submit...

[csmartdalton, 2016-10-04 20:28:55]

On 2016/10/04 20:25:35, mtklein wrote:
> On 2016/10/04 20:24:38, csmartdalton wrote:
> > On 2016/10/04 20:23:17, mtklein wrote:
> > > On 2016/10/04 20:21:25, csmartdalton wrote:
> > > > On 2016/10/04 20:19:14, mtklein wrote:
> > > > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > > > 
> > > > > I don't think that can possibly be true.
> > > > 
> > > > The failing build that was fixed by this change would suggest otherwise.
> > > > 
> > > > And the error message shows that intptr_t == int on Derek's platform.
> > > > 
> > > > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
> > somewhere
> > > to
> > > > verify?
> > > 
> > > static_assert(sizeof(intptr_t) == sizeof(void*), "");
> > 
> > I can't do it locally, this only shows up on the android framework builds,
> which
> > I am not set up with.
> 
> Add that to literally any .cpp file and submit...

AFAIK there not trybots for the framework yet

[csmartdalton, 2016-10-04 20:29:08]

The CQ bit was unchecked by csmartdalton@google.com

[mtklein, 2016-10-04 20:35:22]

On 2016/10/04 20:28:55, csmartdalton wrote:
> On 2016/10/04 20:25:35, mtklein wrote:
> > On 2016/10/04 20:24:38, csmartdalton wrote:
> > > On 2016/10/04 20:23:17, mtklein wrote:
> > > > On 2016/10/04 20:21:25, csmartdalton wrote:
> > > > > On 2016/10/04 20:19:14, mtklein wrote:
> > > > > > > Looks like sizeof(intptr_t) < sizeof(void*) sometimes.
> > > > > > 
> > > > > > I don't think that can possibly be true.
> > > > > 
> > > > > The failing build that was fixed by this change would suggest
otherwise.
> > > > > 
> > > > > And the error message shows that intptr_t == int on Derek's platform.
> > > > > 
> > > > > Derek.. Would it be hard to dump sizeof(intptr_t) and sizeof(void*)
> > > somewhere
> > > > to
> > > > > verify?
> > > > 
> > > > static_assert(sizeof(intptr_t) == sizeof(void*), "");
> > > 
> > > I can't do it locally, this only shows up on the android framework builds,
> > which
> > > I am not set up with.
> > 
> > Add that to literally any .cpp file and submit...
> 
> AFAIK there not trybots for the framework yet

VkFence is 64-bit, even on 32-bit builds.  This also needs to be uint64_t in
order to hold a VkFence.

[csmartdalton, 2016-10-04 21:00:38]

Description was changed from

==========
Use void* again for PlatformFence

Looks like sizeof(intptr_t) < sizeof(void*) sometimes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002
==========

to

==========
Use uint64_t for PlatformFence

VkFence is 64 bit even on 32-bit platforms.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002
==========

[csmartdalton, 2016-10-04 21:02:22]

Good point on uint64_T

[mtklein, 2016-10-04 21:03:41]

lgtm

[csmartdalton, 2016-10-04 21:05:38]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-10-04 21:05:38]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2391113002/#ps40001
(title: "Use uint64_t for PlatformFence")

[commit-bot: I haz the power, 2016-10-04 21:05:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stephana, 2016-10-04 21:19:00]

On 2016/10/04 21:05:50, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm

[commit-bot: I haz the power, 2016-10-04 21:24:25]

Description was changed from

==========
Use uint64_t for PlatformFence

VkFence is 64 bit even on 32-bit platforms.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002
==========

to

==========
Use uint64_t for PlatformFence

VkFence is 64 bit even on 32-bit platforms.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002

Committed:
https://skia.googlesource.com/skia/+/024229a38d86fc53801092e149d8599b2b2bc9fb
==========

[commit-bot: I haz the power, 2016-10-04 21:24:26]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/024229a38d86fc53801092e149d8599b2b2bc9fb