Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting for it to be fully processed.  Protected by FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into QuicSentPacketManager, because it's identical for all send algorithms. No functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=

Committed: https://crrev.com/f6f9fbd9ea50ef8df383d282f9afa5e1e1091dbe
Cr-Commit-Position: refs/heads/master@{#423674}

[rjshade, 2016-10-05 18:39:20]

Description was changed from

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
==========

to

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
==========

[rjshade, 2016-10-05 18:39:20]

rjshade@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-10-06 02:17:49]

Woo hoo!

LGTM

[Ryan Hamilton, 2016-10-06 02:18:00]

On 2016/10/06 02:17:49, Ryan Hamilton wrote:
> Woo hoo!
> 
> LGTM

(Though please fix the flag name)

[rjshade, 2016-10-06 19:24:45]

On 2016/10/06 02:18:00, Ryan Hamilton wrote:
> On 2016/10/06 02:17:49, Ryan Hamilton wrote:
> > Woo hoo!
> > 
> > LGTM
> 
> (Though please fix the flag name)

Fixed the flag name.

[rjshade, 2016-10-06 19:24:50]

The CQ bit was checked by rjshade@chromium.org

[rjshade, 2016-10-06 19:24:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2391103003/#ps40001
(title: "Fix flag name.")

[commit-bot: I haz the power, 2016-10-06 19:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:46:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:46:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjshade, 2016-10-06 19:56:14]

The CQ bit was checked by rjshade@chromium.org

[rjshade, 2016-10-06 19:56:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2391103003/#ps60001
(title: "Add new error code to quic_error_mapping.cc")

[commit-bot: I haz the power, 2016-10-06 19:56:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:00:59]

Description was changed from

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
==========

to

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
==========

[commit-bot: I haz the power, 2016-10-06 21:01:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-06 21:02:27]

Description was changed from

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
==========

to

==========
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4

Record a QUIC packet as received once it's been decrypted, instead of waiting
for it to be fully processed.  Protected by
FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/

Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No
behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/

Remove unused "bytes" argument from
QuicReceivedPacketManager::RecordPacketReceived.  No functional change, not flag
protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/

Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/

Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/

Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/

Move the logic from SendAlgorithmInterface::RetransmissionDelay() into
QuicSentPacketManager, because it's identical for all send algorithms. No
functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/

StringPiece will be replaced with std::string_view. std::string_view doesn't
have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/

short circuit QUIC packets to packet buffer if there is already a CHLO on same
connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/

Conversion of a QUIC method to an async signature and resulting fallout. No
functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/

Add a QUIC connection option to use a more conservative handshake retransmission
timer.  Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/

Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=

Committed: https://crrev.com/f6f9fbd9ea50ef8df383d282f9afa5e1e1091dbe
Cr-Commit-Position: refs/heads/master@{#423674}
==========

[commit-bot: I haz the power, 2016-10-06 21:02:28]

Patchset 4 (id:??) landed as
https://crrev.com/f6f9fbd9ea50ef8df383d282f9afa5e1e1091dbe
Cr-Commit-Position: refs/heads/master@{#423674}