Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: content/browser/webui/web_ui_data_source_unittest.cc

Issue 2391073005: WebUIDataSource::AddInteger (like AddBoolean/AddString) (Closed)
Patch Set: DateTimeHandler usage of SetInteger Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/memory/ref_counted_memory.h" 7 #include "base/memory/ref_counted_memory.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "content/browser/webui/web_ui_data_source_impl.h" 9 #include "content/browser/webui/web_ui_data_source_impl.h"
10 #include "content/public/test/test_browser_thread_bundle.h" 10 #include "content/public/test/test_browser_thread_bundle.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 std::string result(data->front_as<char>(), data->size()); 96 std::string result(data->front_as<char>(), data->size());
97 EXPECT_NE(result.find("loadTimeData.data = {"), std::string::npos); 97 EXPECT_NE(result.find("loadTimeData.data = {"), std::string::npos);
98 EXPECT_NE(result.find("};"), std::string::npos); 98 EXPECT_NE(result.find("};"), std::string::npos);
99 } 99 }
100 100
101 TEST_F(WebUIDataSourceTest, EmptyStrings) { 101 TEST_F(WebUIDataSourceTest, EmptyStrings) {
102 source()->SetJsonPath("strings.js"); 102 source()->SetJsonPath("strings.js");
103 StartDataRequest("strings.js", base::Bind(&EmptyStringsCallback)); 103 StartDataRequest("strings.js", base::Bind(&EmptyStringsCallback));
104 } 104 }
105 105
106 void SomeStringsCallback(scoped_refptr<base::RefCountedMemory> data) { 106 void SomeValuesCallback(scoped_refptr<base::RefCountedMemory> data) {
107 std::string result(data->front_as<char>(), data->size()); 107 std::string result(data->front_as<char>(), data->size());
108 EXPECT_NE(result.find("\"flag\":true"), std::string::npos);
109 EXPECT_NE(result.find("\"counter\":10"), std::string::npos);
110 EXPECT_NE(result.find("\"debt\":-456"), std::string::npos);
108 EXPECT_NE(result.find("\"planet\":\"pluto\""), std::string::npos); 111 EXPECT_NE(result.find("\"planet\":\"pluto\""), std::string::npos);
109 EXPECT_NE(result.find("\"button\":\"foo\""), std::string::npos); 112 EXPECT_NE(result.find("\"button\":\"foo\""), std::string::npos);
110 } 113 }
111 114
112 TEST_F(WebUIDataSourceTest, SomeStrings) { 115 TEST_F(WebUIDataSourceTest, SomeValues) {
113 source()->SetJsonPath("strings.js"); 116 source()->SetJsonPath("strings.js");
117 source()->AddBoolean("flag", true);
118 source()->AddInteger("counter", 10);
119 source()->AddInteger("debt", -456);
114 source()->AddString("planet", base::ASCIIToUTF16("pluto")); 120 source()->AddString("planet", base::ASCIIToUTF16("pluto"));
115 source()->AddLocalizedString("button", kDummyStringId); 121 source()->AddLocalizedString("button", kDummyStringId);
116 StartDataRequest("strings.js", base::Bind(&SomeStringsCallback)); 122 StartDataRequest("strings.js", base::Bind(&SomeValuesCallback));
117 } 123 }
118 124
119 void DefaultResourceFoobarCallback(scoped_refptr<base::RefCountedMemory> data) { 125 void DefaultResourceFoobarCallback(scoped_refptr<base::RefCountedMemory> data) {
120 std::string result(data->front_as<char>(), data->size()); 126 std::string result(data->front_as<char>(), data->size());
121 EXPECT_NE(result.find(kDummyDefaultResource), std::string::npos); 127 EXPECT_NE(result.find(kDummyDefaultResource), std::string::npos);
122 } 128 }
123 129
124 void DefaultResourceStringsCallback( 130 void DefaultResourceStringsCallback(
125 scoped_refptr<base::RefCountedMemory> data) { 131 scoped_refptr<base::RefCountedMemory> data) {
126 std::string result(data->front_as<char>(), data->size()); 132 std::string result(data->front_as<char>(), data->size());
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 EXPECT_EQ(GetMimeType(".css.foo"), html); 206 EXPECT_EQ(GetMimeType(".css.foo"), html);
201 207
202 // With query strings. 208 // With query strings.
203 EXPECT_EQ(GetMimeType("foo?abc?abc"), html); 209 EXPECT_EQ(GetMimeType("foo?abc?abc"), html);
204 EXPECT_EQ(GetMimeType("foo.html?abc?abc"), html); 210 EXPECT_EQ(GetMimeType("foo.html?abc?abc"), html);
205 EXPECT_EQ(GetMimeType("foo.css?abc?abc"), css); 211 EXPECT_EQ(GetMimeType("foo.css?abc?abc"), css);
206 EXPECT_EQ(GetMimeType("foo.js?abc?abc"), js); 212 EXPECT_EQ(GetMimeType("foo.js?abc?abc"), js);
207 } 213 }
208 214
209 } // namespace content 215 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/webui/web_ui_data_source_impl.cc ('k') | content/public/browser/web_ui_data_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698