[Findit] Fix flaky tests due to importing pytz.

[Findit] Fix flaky tests due to importing pytz.

BUG=652777
Committed: https://chromium.googlesource.com/infra/infra/+/4a1905687b069669d910806d67775bef70d7377a

[stgao, 2016-10-04 18:09:28]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, katesonia@chromium.org, lijeffrey@chromium.org

[stgao, 2016-10-04 18:09:29]

ptal

[chanli, 2016-10-04 18:16:35]

On 2016/10/04 18:09:29, stgao (slow) wrote:
> ptal

lgtm

[Sharu Jiang, 2016-10-04 18:17:43]

lgtm

[lijeffrey, 2016-10-04 18:17:50]

lgtm with nits

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
(right):

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:82:
mocked_pst_eta = datetime(2016, 9, 20, 18, 0, 10, 0)  # With random delay.
nit: instead of saying "random" delay which makes it sound like it should be
generated randomly at run time when it's actually hard-coded, how about say
"with arbitrary delay of 10 seconds."?

Same with the other comment below.

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:89:
random_func.side_effect = [10, None]
nit: is this 10 the same "random" delay as in 82? If so, how about factor it out
into a variable to make this test more clear?

[stgao, 2016-10-04 18:27:12]

Description was changed from

==========
[Findit] Fix flaky tests due to importing pytz.

BUG=
==========

to

==========
[Findit] Fix flaky tests due to importing pytz.

BUG=652777
==========

[stgao, 2016-10-04 18:27:28]

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
(right):

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:82:
mocked_pst_eta = datetime(2016, 9, 20, 18, 0, 10, 0)  # With random delay.
On 2016/10/04 18:17:49, lijeffrey wrote:
> nit: instead of saying "random" delay which makes it sound like it should be
> generated randomly at run time when it's actually hard-coded, how about say
> "with arbitrary delay of 10 seconds."?
> 
> Same with the other comment below.

Done.

https://codereview.chromium.org/2391063002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py:89:
random_func.side_effect = [10, None]
On 2016/10/04 18:17:49, lijeffrey wrote:
> nit: is this 10 the same "random" delay as in 82? If so, how about factor it
out
> into a variable to make this test more clear?

Done.

[stgao, 2016-10-04 18:27:32]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-10-04 18:27:32]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
katesonia@chromium.org, lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2391063002/#ps20001
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-10-04 18:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:42:00]

Description was changed from

==========
[Findit] Fix flaky tests due to importing pytz.

BUG=652777
==========

to

==========
[Findit] Fix flaky tests due to importing pytz.

BUG=652777

Committed:
https://chromium.googlesource.com/infra/infra/+/4a1905687b069669d910806d67775...
==========

[commit-bot: I haz the power, 2016-10-04 18:42:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/4a1905687b069669d910806d67775...