[Downloads UI] Handle multiple onAllDownloadItemsRetrieved() calls

[Downloads UI] Handle multiple onAllDownloadItemsRetrieved() calls

If onAllDownloadItemsRetrieved() has already been called, return
early rather than repopulating lists.

BUG=652650
Committed: https://crrev.com/61079eb837e97658c332e54fbcfe5c13b95b1d7f
Cr-Commit-Position: refs/heads/master@{#422922}

[Theresa, 2016-10-04 17:55:03]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:55:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:44:12]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-10-04 19:00:27]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-10-04 19:00:27]

ptal

[gone, 2016-10-04 20:05:34]

lgtm

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:104:
|| (isOffTheRecord && mAllOffTheRecordDownloadItemsRetrieved)) return;
two lines, gotta do braces

nit: I'd also make this check and set the variables as necessary to keep them
close together

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:145:
mAllOfflinePagesRetrieved = true;
move this right under the check above

[Theresa, 2016-10-04 20:09:07]

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:104:
|| (isOffTheRecord && mAllOffTheRecordDownloadItemsRetrieved)) return;
On 2016/10/04 20:05:34, dfalcantara (slow) wrote:
> two lines, gotta do braces
> 
> nit: I'd also make this check and set the variables as necessary to keep them
> close together

Done.

https://codereview.chromium.org/2391053002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:145:
mAllOfflinePagesRetrieved = true;
On 2016/10/04 20:05:34, dfalcantara (slow) wrote:
> move this right under the check above

Done.

[Theresa, 2016-10-04 20:09:29]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-04 20:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2391053002/#ps20001
(title: "[Downloads UI] Handle multiple onAllDownloadItemsRetrieved() calls")

[commit-bot: I haz the power, 2016-10-04 20:10:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:53:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 20:55:42]

Description was changed from

==========
[Downloads UI] Handle multiple onAllDownloadItemsRetrieved() calls

If onAllDownloadItemsRetrieved() has already been called, return
early rather than repopulating lists.

BUG=652650
==========

to

==========
[Downloads UI] Handle multiple onAllDownloadItemsRetrieved() calls

If onAllDownloadItemsRetrieved() has already been called, return
early rather than repopulating lists.

BUG=652650

Committed: https://crrev.com/61079eb837e97658c332e54fbcfe5c13b95b1d7f
Cr-Commit-Position: refs/heads/master@{#422922}
==========

[commit-bot: I haz the power, 2016-10-04 20:55:43]

Patchset 2 (id:??) landed as
https://crrev.com/61079eb837e97658c332e54fbcfe5c13b95b1d7f
Cr-Commit-Position: refs/heads/master@{#422922}