Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/crankshaft/x64/lithium-x64.cc

Issue 2391043005: [crankshaft] Remove HLoadKeyedGeneric and use HCallWithDescriptor to call KeyedLoadIC. (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x64/lithium-x64.h" 5 #include "src/crankshaft/x64/lithium-x64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X64 9 #if V8_TARGET_ARCH_X64
10 10
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2111 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub()); 2111 (instr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED && info()->IsStub());
2112 } 2112 }
2113 2113
2114 if (needs_environment) { 2114 if (needs_environment) {
2115 result = AssignEnvironment(result); 2115 result = AssignEnvironment(result);
2116 } 2116 }
2117 return result; 2117 return result;
2118 } 2118 }
2119 2119
2120 2120
2121 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2122 LOperand* context = UseFixed(instr->context(), rsi);
2123 LOperand* object =
2124 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2125 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
2126 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2127
2128 LLoadKeyedGeneric* result =
2129 new(zone()) LLoadKeyedGeneric(context, object, key, vector);
2130 return MarkAsCall(DefineFixed(result, rax), instr);
2131 }
2132
2133
2134 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) { 2121 LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {
2135 ElementsKind elements_kind = instr->elements_kind(); 2122 ElementsKind elements_kind = instr->elements_kind();
2136 2123
2137 if ((kPointerSize == kInt64Size) && instr->IsDehoisted()) { 2124 if ((kPointerSize == kInt64Size) && instr->IsDehoisted()) {
2138 FindDehoistedKeyDefinitions(instr->key()); 2125 FindDehoistedKeyDefinitions(instr->key());
2139 } 2126 }
2140 2127
2141 if (!instr->is_fixed_typed_array()) { 2128 if (!instr->is_fixed_typed_array()) {
2142 DCHECK(instr->elements()->representation().IsTagged()); 2129 DCHECK(instr->elements()->representation().IsTagged());
2143 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2130 bool needs_write_barrier = instr->NeedsWriteBarrier();
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
2505 LOperand* index = UseTempRegister(instr->index()); 2492 LOperand* index = UseTempRegister(instr->index());
2506 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2493 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2507 LInstruction* result = DefineSameAsFirst(load); 2494 LInstruction* result = DefineSameAsFirst(load);
2508 return AssignPointerMap(result); 2495 return AssignPointerMap(result);
2509 } 2496 }
2510 2497
2511 } // namespace internal 2498 } // namespace internal
2512 } // namespace v8 2499 } // namespace v8
2513 2500
2514 #endif // V8_TARGET_ARCH_X64 2501 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698