Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: third_party/WebKit/Source/platform/transforms/RotationTest.cpp

Issue 2391003004: Fix common axes logic to detect negated axes as not common (Closed)
Patch Set: Update expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/transforms/RotationTest.cpp
diff --git a/third_party/WebKit/Source/platform/transforms/RotationTest.cpp b/third_party/WebKit/Source/platform/transforms/RotationTest.cpp
index e5290c7f53bb5e60b8dc1f82c0fea82197b0a199..d775e2117146311dd03f513aa8e2119ef981229d 100644
--- a/third_party/WebKit/Source/platform/transforms/RotationTest.cpp
+++ b/third_party/WebKit/Source/platform/transforms/RotationTest.cpp
@@ -58,6 +58,10 @@ TEST(RotationTest, GetCommonAxisTest) {
EXPECT_FALSE(Rotation::getCommonAxis(Rotation(FloatPoint3D(1, 2, 3), 50),
Rotation(FloatPoint3D(3, 2, 1), 100),
axis, angleA, angleB));
+
+ EXPECT_FALSE(Rotation::getCommonAxis(Rotation(FloatPoint3D(1, 2, 3), 50),
+ Rotation(FloatPoint3D(-1, -2, -3), 100),
+ axis, angleA, angleB));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698