Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2390993002: Revert of Automatically copy the DIA DLL in the Syzygy binaries directory. (Closed)

Created:
4 years, 2 months ago by Sébastien Marchand
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Automatically copy the DIA DLL in the Syzygy binaries directory. (patchset #11 id:240001 of https://codereview.chromium.org/2365893002/ ) Reason for revert: Break gclient for the open contributors. Original issue's description: > Automatically copy the DIA DLL in the Syzygy binaries directory. > > Committed: https://crrev.com/f34c072397b99c313e79cd10a77f5ca397154399 > Cr-Commit-Position: refs/heads/master@{#422655} TBR=chrisha@chromium.org,siggi@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bcc865c6e04ee070d0745c645c5bcc0d1cb890bc Cr-Commit-Position: refs/heads/master@{#422767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M build/get_syzygy_binaries.py View 4 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
Created Revert of Automatically copy the DIA DLL in the Syzygy binaries directory.
4 years, 2 months ago (2016-10-04 12:42:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390993002/1
4 years, 2 months ago (2016-10-04 12:42:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 12:43:09 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:46:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc865c6e04ee070d0745c645c5bcc0d1cb890bc
Cr-Commit-Position: refs/heads/master@{#422767}

Powered by Google App Engine
This is Rietveld 408576698