Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2390983002: Provide route ID via URLLoaderFactory (Closed)

Created:
4 years, 2 months ago by yhirano
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide route ID via URLLoaderFactory BUG=603396 Committed: https://crrev.com/7a9db51038a0854f64e8ba6aa6c49e35b015fbff Cr-Commit-Position: refs/heads/master@{#423011}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M content/browser/loader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 9 chunks +22 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/url_loader_factory.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yhirano
jam@, can you take a look? Background: https://groups.google.com/a/chromium.org/forum/#!searchin/loading-dev/render$20view%7Csort:relevance/loading-dev/lHE8VojBFHg/a9HwEN0-BwAJ
4 years, 2 months ago (2016-10-04 14:12:12 UTC) #8
jam
lgtm
4 years, 2 months ago (2016-10-04 16:05:09 UTC) #11
yhirano
+tsepez@ for content/common/url_loader_factory.mojom
4 years, 2 months ago (2016-10-04 16:27:00 UTC) #13
Tom Sepez
mojom LGTM
4 years, 2 months ago (2016-10-04 18:27:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390983002/20001
4 years, 2 months ago (2016-10-05 00:03:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 00:10:57 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:13:15 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a9db51038a0854f64e8ba6aa6c49e35b015fbff
Cr-Commit-Position: refs/heads/master@{#423011}

Powered by Google App Engine
This is Rietveld 408576698