[Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace.

base/mac/launch_services_util.h

Index: base/mac/launch_services_util.h
diff --git a/base/mac/launch_services_util.h b/base/mac/launch_services_util.h
index 0e64316052b3e04da9bc472201f8a9fb1994ef55..ae2a28fb3c498cb41a744f14b3cb2228326bda32 100644
--- a/base/mac/launch_services_util.h
+++ b/base/mac/launch_services_util.h
@@ -5,27 +5,25 @@
 #ifndef BASE_MAC_LAUNCH_SERVICES_UTIL_H_
 #define BASE_MAC_LAUNCH_SERVICES_UTIL_H_
 
-#include <CoreServices/CoreServices.h>
+#import <AppKit/AppKit.h>
 
 #include "base/base_export.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
-
-struct ProcessSerialNumber;
+#include "base/process/process.h"
 
 namespace base {
 namespace mac {
 
 // Launches the application bundle at |bundle_path|, passing argv[1..] from
 // |command_line| as command line arguments if the app isn't already running.
-// |launch_flags| are passed directly to LSApplicationParameters.
-// |out_psn|, if not NULL, will be set to the process serial number of the
-// application's main process if the app was successfully launched.
-// Returns true if the app was successfully launched.
-BASE_EXPORT bool OpenApplicationWithPath(const FilePath& bundle_path,
-                                         const CommandLine& command_line,
-                                         LSLaunchFlags launch_flags,
-                                         ProcessSerialNumber* out_psn);
+// |launch_options| are passed directly to
+// -[NSWorkspace launchApplicationAtURL:options:configuration:error:] without
+// first entry. Returns a valid process if the app was successfully launched.

[tapted, 2016/10/05 01:40:47]

"without first entry" is a bit ambiguous here. I think we can remove that bit of
the sentence - callers can just assume it does the "right thing" as far as argv
is concerned.

[Eugene But (OOO till 7-30), 2016/10/05 01:49:51]

Alright. I actually added this because you were not sure why first entry was
removed.

+BASE_EXPORT Process
+OpenApplicationWithPath(const FilePath& bundle_path,
+                        const CommandLine& command_line,
+                        NSWorkspaceLaunchOptions launch_options);
 
 }  // namespace mac
 }  // namespace base