Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: base/mac/launch_services_util.h

Issue 2390953003: [Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace. (Closed)
Patch Set: Self review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mac/launch_services_util.h
diff --git a/base/mac/launch_services_util.h b/base/mac/launch_services_util.h
index 0e64316052b3e04da9bc472201f8a9fb1994ef55..0a7a5ab52403113de2a35aa4e2fa9b383afcd426 100644
--- a/base/mac/launch_services_util.h
+++ b/base/mac/launch_services_util.h
@@ -5,7 +5,7 @@
#ifndef BASE_MAC_LAUNCH_SERVICES_UTIL_H_
#define BASE_MAC_LAUNCH_SERVICES_UTIL_H_
-#include <CoreServices/CoreServices.h>
+#import <AppKit/AppKit.h>
#include "base/base_export.h"
#include "base/command_line.h"
@@ -18,14 +18,16 @@ namespace mac {
// Launches the application bundle at |bundle_path|, passing argv[1..] from
// |command_line| as command line arguments if the app isn't already running.
-// |launch_flags| are passed directly to LSApplicationParameters.
-// |out_psn|, if not NULL, will be set to the process serial number of the
-// application's main process if the app was successfully launched.
-// Returns true if the app was successfully launched.
-BASE_EXPORT bool OpenApplicationWithPath(const FilePath& bundle_path,
- const CommandLine& command_line,
- LSLaunchFlags launch_flags,
- ProcessSerialNumber* out_psn);
+// |launch_options| are passed directly to
+// -[NSWorkspace launchApplicationAtURL:options:configuration:error:].
+// |out_pid|, if not null, will be set to the process id of the application's
+// main process if the app was successfully launched. Returns true if the app
+// was successfully launched.
+BASE_EXPORT bool OpenApplicationWithPath(
tapted 2016/10/04 05:54:08 Since the API is changing anyway... returning a ba
Eugene But (OOO till 7-30) 2016/10/04 07:02:49 Done.
+ const FilePath& bundle_path,
+ const CommandLine& command_line,
+ NSWorkspaceLaunchOptions launch_options,
+ pid_t* out_pid);
} // namespace mac
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698