Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 2390953003: [Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace. (Closed)
Patch Set: Addressed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index 4288a2b50bd8bd52241660b9bfae9e242c61bc66..710a6259e02d1ca6aa8479ed03c3fca6bfb5ad72 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -15,7 +15,7 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/launch_services_util.h"
+#import "base/mac/launch_services_util.h"
#include "base/mac/mac_util.h"
#include "base/mac/scoped_cftyperef.h"
#include "base/mac/scoped_nsobject.h"
@@ -277,9 +277,10 @@ void LaunchShimOnFileThread(
base::IntToString(base::GetCurrentProcId()));
if (launched_after_rebuild)
command_line.AppendSwitch(app_mode::kLaunchedAfterRebuild);
- // Launch without activating (kLSLaunchDontSwitch).
+ // Launch without activating (NSWorkspaceLaunchWithoutActivation).
base::mac::OpenApplicationWithPath(
- shim_path, command_line, kLSLaunchDefaults | kLSLaunchDontSwitch, NULL);
+ shim_path, command_line,
+ NSWorkspaceLaunchDefault | NSWorkspaceLaunchWithoutActivation);
}
base::FilePath GetAppLoaderPath() {
« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698