Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: chrome/app_shim/app_mode_loader_mac.mm

Issue 2390953003: [Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace. (Closed)
Patch Set: Addressed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/mac/launch_services_util.mm ('k') | chrome/app_shim/chrome_main_app_mode_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app_shim/app_mode_loader_mac.mm
diff --git a/chrome/app_shim/app_mode_loader_mac.mm b/chrome/app_shim/app_mode_loader_mac.mm
index 1d55ffcadb53e1ea6d7098fe7f141681477934ff..e4a3686f1a693d4c20903fff5b58cb95b208b88a 100644
--- a/chrome/app_shim/app_mode_loader_mac.mm
+++ b/chrome/app_shim/app_mode_loader_mac.mm
@@ -17,7 +17,7 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/launch_services_util.h"
+#import "base/mac/launch_services_util.h"
#include "base/mac/scoped_nsautorelease_pool.h"
#include "base/process/launch.h"
#include "base/strings/string_number_conversions.h"
@@ -182,8 +182,7 @@ int LoadFrameworkAndStart(app_mode::ChromeAppModeInfo* info) {
command_line.AppendSwitchASCII(switches::kAppId, info->app_mode_id);
}
// Launch the executable directly since base::mac::OpenApplicationWithPath
- // uses LSOpenApplication which doesn't pass command line arguments if the
- // application is already running.
+ // doesn't pass command line arguments if the application is already running.
if (!base::LaunchProcess(command_line, base::LaunchOptions()).IsValid()) {
LOG(ERROR) << "Could not launch Chrome: "
<< command_line.GetCommandLineString();
« no previous file with comments | « base/mac/launch_services_util.mm ('k') | chrome/app_shim/chrome_main_app_mode_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698