[Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace.

chrome/app_shim/chrome_main_app_mode_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // On Mac, one can't make shortcuts with command-line arguments. Instead, we
 // produce small app bundles which locate the Chromium framework and load it,
 // passing the appropriate data. This is the entry point into the framework for
 // those app bundles.
 
 #import <Cocoa/Cocoa.h>
 #include <vector>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
-#include "base/mac/launch_services_util.h"
+#import "base/mac/launch_services_util.h"
 #include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 643 matching lines @@
 
     // If the shim is the app launcher, pass --show-app-list when starting a new
     // Chrome process to inform startup codepaths and load the correct profile.
     if (info->app_mode_id == app_mode::kAppListModeId) {
       command_line.AppendSwitch(switches::kShowAppList);
     } else {
       command_line.AppendSwitchPath(switches::kProfileDirectory,
                                     info->profile_dir);
     }
 
-    bool success =
-        base::mac::OpenApplicationWithPath(base::mac::OuterBundlePath(),
-                                           command_line,
-                                           kLSLaunchDefaults,
-                                           &psn);
-    if (!success)
+    base::Process app = base::mac::OpenApplicationWithPath(
+        base::mac::OuterBundlePath(), command_line, NSWorkspaceLaunchDefault);
+
+    // TODO(crbug.com/652563): Do not use deprecated GetProcessForPID. Change
+    // |ReplyEventHandler| to take |pid_t| instead of |ProcessSerialNumber|.
+    if (!app.IsValid() || GetProcessForPID(app.Pid(), &psn) != noErr)
       return 1;
 
     base::Callback<void(bool)> on_ping_chrome_reply =
         base::Bind(&AppShimController::OnPingChromeReply,
                    base::Unretained(&controller));
 
     // This code abuses the fact that Apple Events sent before the process is
     // fully initialized don't receive a reply until its run loop starts. Once
     // the reply is received, Chrome will have opened its IPC port, guaranteed.
     [ReplyEventHandler pingProcess:psn
                            andCall:on_ping_chrome_reply];
 
     main_message_loop.task_runner()->PostDelayedTask(
         FROM_HERE, base::Bind(&AppShimController::OnPingChromeTimeout,
                               base::Unretained(&controller)),
         base::TimeDelta::FromSeconds(kPingChromeTimeoutSeconds));
   } else {
     // Chrome already running. Proceed to init. This could still fail if Chrome
     // is still starting up or shutting down, but the process will exit quickly,
     // which is preferable to waiting for the Apple Event to timeout after one
     // minute.
     main_message_loop.task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&AppShimController::Init, base::Unretained(&controller)));
   }
 
   base::RunLoop().Run();
   return 0;
 }