ServiceWorker: Remove an unused origin_filter param for cleanup

ServiceWorker: Remove an unused origin_filter param for cleanup

This CL removes an unused |origin_filter| param from DidGetRegistrationsInfo()
on ServiceWorkerStorage. Before this CL, the param was always an empty GURL.

In addition, this makes DidGetRegistrations() always take a non-empty GURL as
|origin_filter| and renames the function to DidGetRegistrationsForOrigin() to
clarify its functionality.

BUG=n/a

Committed: https://crrev.com/b49cc0f48221deda964b115e1f3576883f217b9c
Cr-Commit-Position: refs/heads/master@{#422721}

[nhiroki, 2016-10-04 03:37:13]

Description was changed from

==========
ServiceWorker: Remove an unused origin_filter param for cleanup

BUG=n/a
==========

to

==========
ServiceWorker: Remove an unused origin_filter param for cleanup

This CL removes an unused |origin_filter| param from DidGetRegistrationsInfo()
on ServiceWorkerStorage. Before this CL, the param was always an empty GURL.

In addition, this makes DidGetRegistrations() always take a non-empty GURL as
|origin_filter| and renames the function to DidGetRegistrationsForOrigin() to
clarify its functionality.

BUG=n/a
==========

[nhiroki, 2016-10-04 03:37:23]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 03:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-10-04 03:38:48]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, shimazu@chromium.org

[nhiroki, 2016-10-04 03:38:49]

PTAL, thanks!

[shimazu, 2016-10-04 03:52:07]

https://codereview.chromium.org/2390953002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_storage.h (right):

https://codereview.chromium.org/2390953002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_storage.h:369: void
DidGetAllRegistrations(const GetRegistrationsInfosCallback& callback,
I feel DidGetAllRegistrationsInfos is better because 'DidGetAllRegistrations'
seems to return a sort of std::vector<SWRegistration>, but the type of argument
is std::vector<SWRegistrationInfo>.

[falken, 2016-10-04 04:03:19]

lgtm

[nhiroki, 2016-10-04 04:13:22]

Thank you. Updated.

https://codereview.chromium.org/2390953002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_storage.h (right):

https://codereview.chromium.org/2390953002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_storage.h:369: void
DidGetAllRegistrations(const GetRegistrationsInfosCallback& callback,
On 2016/10/04 03:52:07, shimazu wrote:
> I feel DidGetAllRegistrationsInfos is better because 'DidGetAllRegistrations'
> seems to return a sort of std::vector<SWRegistration>, but the type of
argument
> is std::vector<SWRegistrationInfo>.

Done.

[shimazu, 2016-10-04 04:55:58]

lgtm too!

[nhiroki, 2016-10-04 04:56:08]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-10-04 04:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2390953002/#ps40001
(title: "slightly revert renaming for consistency")

[commit-bot: I haz the power, 2016-10-04 04:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 06:10:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 06:12:51]

Description was changed from

==========
ServiceWorker: Remove an unused origin_filter param for cleanup

This CL removes an unused |origin_filter| param from DidGetRegistrationsInfo()
on ServiceWorkerStorage. Before this CL, the param was always an empty GURL.

In addition, this makes DidGetRegistrations() always take a non-empty GURL as
|origin_filter| and renames the function to DidGetRegistrationsForOrigin() to
clarify its functionality.

BUG=n/a
==========

to

==========
ServiceWorker: Remove an unused origin_filter param for cleanup

This CL removes an unused |origin_filter| param from DidGetRegistrationsInfo()
on ServiceWorkerStorage. Before this CL, the param was always an empty GURL.

In addition, this makes DidGetRegistrations() always take a non-empty GURL as
|origin_filter| and renames the function to DidGetRegistrationsForOrigin() to
clarify its functionality.

BUG=n/a

Committed: https://crrev.com/b49cc0f48221deda964b115e1f3576883f217b9c
Cr-Commit-Position: refs/heads/master@{#422721}
==========

[commit-bot: I haz the power, 2016-10-04 06:12:53]

Patchset 3 (id:??) landed as
https://crrev.com/b49cc0f48221deda964b115e1f3576883f217b9c
Cr-Commit-Position: refs/heads/master@{#422721}