Don't skip hole checks inside patterns in parameter lists

Don't skip hole checks inside patterns in parameter lists

Previously, b6e9f625c17f3a688139426771e2cb34fbdcb46e fixed self-assignment
in parameters to throw. But it failed to deal with the case of
destructuring with defaults. This patch extends that previous approach
to always treat the end of a parameter as its initializer position,
whether it has an initializer or not.

This is the minimal change to make it easy to merge; a follow-up
will rename the field of Parameter from "initializer_end_position"
to "end_position".

BUG=v8:5454
Committed: https://crrev.com/3c39bac4403dddc5b8d74aefd1cb06a967a2c4f1
Cr-Commit-Position: refs/heads/master@{#39962}

[adamk, 2016-10-04 01:22:13]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:22:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-04 01:22:39]

adamk@chromium.org changed reviewers:
+ neis@chromium.org

[adamk, 2016-10-04 01:22:53]

adamk@chromium.org changed reviewers:
+ caitp@igalia.com

[commit-bot: I haz the power, 2016-10-04 01:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:53:55]

Dry run: This issue passed the CQ dry run.

[neis, 2016-10-04 08:58:07]

lgtm

[adamk, 2016-10-04 17:01:49]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:01:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:04:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 17:04:27]

Description was changed from

==========
Don't skip hole checks inside patterns in parameter lists

Previously, b6e9f625c17f3a688139426771e2cb34fbdcb46e fixed self-assignment
in parameters to throw. But it failed to deal with the case of
destructuring with defaults. This patch extends that previous approach
to always treat the end of a parameter as its initializer position,
whether it has an initializer or not.

This is the minimal change to make it easy to merge; a follow-up
will rename the field of Parameter from "initializer_end_position"
to "end_position".

BUG=v8:5454
==========

to

==========
Don't skip hole checks inside patterns in parameter lists

Previously, b6e9f625c17f3a688139426771e2cb34fbdcb46e fixed self-assignment
in parameters to throw. But it failed to deal with the case of
destructuring with defaults. This patch extends that previous approach
to always treat the end of a parameter as its initializer position,
whether it has an initializer or not.

This is the minimal change to make it easy to merge; a follow-up
will rename the field of Parameter from "initializer_end_position"
to "end_position".

BUG=v8:5454

Committed: https://crrev.com/3c39bac4403dddc5b8d74aefd1cb06a967a2c4f1
Cr-Commit-Position: refs/heads/master@{#39962}
==========

[commit-bot: I haz the power, 2016-10-04 17:04:28]

Patchset 1 (id:??) landed as
https://crrev.com/3c39bac4403dddc5b8d74aefd1cb06a967a2c4f1
Cr-Commit-Position: refs/heads/master@{#39962}