Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390933003: DevTools: Stop SuggestBox from flickering in TextPrompt (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Stop SuggestBox from flickering in TextPrompt BUG=none Committed: https://crrev.com/1bc946cfb4b7d010297b1ded8ffb14018fb3fc27 Cr-Commit-Position: refs/heads/master@{#423016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-04 20:27:41 UTC) #2
lushnikov
lgtm
4 years, 2 months ago (2016-10-04 21:53:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390933003/1
4 years, 2 months ago (2016-10-04 22:58:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:23:23 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:25:45 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1bc946cfb4b7d010297b1ded8ffb14018fb3fc27
Cr-Commit-Position: refs/heads/master@{#423016}

Powered by Google App Engine
This is Rietveld 408576698