Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 2390933002: Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (Closed)

Created:
4 years, 2 months ago by jaydasika
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, chromium-reviews, darin (slow to review), ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ ) Reason for revert: Speculative revert for build failure : https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/11350 Original issue's description: > bluetooth: Add device list retrieval for chrome://bluetooth-internals > > Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page. > Adds mojom files for Bluetooth service definition and internals page handler. > Adds basic Bluetooth device retrieval using starter Bluetooth service > implementation for logging on web front end. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > BUG=651282 > > Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9 > Cr-Commit-Position: refs/heads/master@{#422570} TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651282, 652494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -307 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/bluetooth_internals/bluetooth_internals.js View 1 chunk +3 lines, -79 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D device/bluetooth/adapter.h View 1 chunk +0 lines, -58 lines 0 comments Download
D device/bluetooth/adapter.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M device/bluetooth/public/interfaces/BUILD.gn View 1 chunk +1 line, -13 lines 0 comments Download
D device/bluetooth/public/interfaces/adapter.mojom View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jaydasika
Created Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals
4 years, 2 months ago (2016-10-03 23:39:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390933002/1
4 years, 2 months ago (2016-10-03 23:40:08 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-03 23:40:56 UTC) #5
scheib
4 years, 2 months ago (2016-10-04 01:55:13 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698