Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: components/metrics/proto/system_profile.proto

Issue 239093004: Move part of metrics from chrome/common to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest that broke after rebase. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/system_profile.proto
diff --git a/chrome/common/metrics/proto/system_profile.proto b/components/metrics/proto/system_profile.proto
similarity index 99%
rename from chrome/common/metrics/proto/system_profile.proto
rename to components/metrics/proto/system_profile.proto
index fd339ec5d26db48c249c9d30b0d7827b1cc0f50a..f7765efa1e8f3b2c77df428d11d450ad83d74113 100644
--- a/chrome/common/metrics/proto/system_profile.proto
+++ b/components/metrics/proto/system_profile.proto
@@ -146,7 +146,8 @@ message SystemProfileProto {
optional string driver_date = 4;
// The GPU performance statistics.
- // See http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/gpu_performance_stats.h?view=markup
+ // See
+ // http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/gpu_performance_stats.h?view=markup
Ilya Sherman 2014/04/15 23:00:40 Ditto
// for details. Currently logged only on Windows.
message PerformanceStatistics {
optional float graphics_score = 1;
@@ -272,7 +273,8 @@ message SystemProfileProto {
// The connection type according to NetworkChangeNotifier.
optional ConnectionType connection_type = 2;
- // Set to true if wifi_phy_layer_protocol changed during the lifetime of the log.
+ // Set to true if wifi_phy_layer_protocol changed during the lifetime of the
+ // log.
Ilya Sherman 2014/04/15 23:00:40 Ditto. It does seem worthwhile to clean up the pr
optional bool wifi_phy_layer_protocol_is_ambiguous = 3;
// See net::WifiPHYLayerProtocol.

Powered by Google App Engine
This is Rietveld 408576698