Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 239093004: Move part of metrics from chrome/common to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest that broke after rebase. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/omnibox_event.proto
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto
similarity index 92%
rename from chrome/common/metrics/proto/omnibox_event.proto
rename to components/metrics/proto/omnibox_event.proto
index f94c63d25b79a143eb91deb07e05e3c70706cb2b..e2572f6fc8630dd495784d98f6bfe698668f27a1 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/components/metrics/proto/omnibox_event.proto
@@ -180,19 +180,19 @@ message OmniboxEventProto {
// contains the input
CONTACT = 12; // DEPRECATED. One of the user's contacts
BOOKMARK_TITLE = 13; // A bookmark whose title contains the input.
- SEARCH_SUGGEST_ENTITY = 14; // A suggested search for an entity.
- SEARCH_SUGGEST_INFINITE = 15; // A suggested search to complete the tail
- // of the query.
- SEARCH_SUGGEST_PERSONALIZED = 16; // A personalized suggested search.
- SEARCH_SUGGEST_PROFILE = 17; // A personalized suggested search for a
- // Google+ profile.
- APP_RESULT = 18; // Result from an installed app
- // (eg: a gmail email).
- // Used by Android GSA for on-device
- // suggestion logging.
- APP = 19; // An app result (eg: the gmail app).
- // Used by Android GSA for on-device
- // suggestion logging.
+ SEARCH_SUGGEST_ENTITY = 14; // A suggested search for an entity.
+ SEARCH_SUGGEST_INFINITE = 15; // A suggested search to complete the tail
+ // of the query.
+ SEARCH_SUGGEST_PERSONALIZED = 16; // A personalized suggested search.
+ SEARCH_SUGGEST_PROFILE = 17; // A personalized suggested search for a
+ // Google+ profile.
+ APP_RESULT = 18; // Result from an installed app
+ // (eg: a gmail email).
+ // Used by Android GSA for on-device
+ // suggestion logging.
+ APP = 19; // An app result (eg: the gmail app).
+ // Used by Android GSA for on-device
+ // suggestion logging.
Ilya Sherman 2014/04/15 23:00:40 nit: Please revert the whitespace changes to this
}
optional ResultType result_type = 2;

Powered by Google App Engine
This is Rietveld 408576698