components/metrics.gypi - Issue 239093004: Move part of metrics from chrome/common to components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics.gypi

Issue 239093004: Move part of metrics from chrome/common to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittest that broke after rebase. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics.gypi

diff --git a/components/metrics.gypi b/components/metrics.gypi

index 6036cae0cf91e3ef123fbdb65ffb35b7a63ebd35..38995d6cd77b0117c19a4bc2f57ebaa44dd538a7 100644

--- a/components/metrics.gypi

+++ b/components/metrics.gypi

@@ -16,7 +16,23 @@

'sources': [

'metrics/metrics_hashes.cc',

'metrics/metrics_hashes.h',

+ 'metrics/metrics_log_base.cc',

+ 'metrics/metrics_log_base.h',

+ 'metrics/metrics_log_manager.cc',

+ 'metrics/metrics_log_manager.h',

+ 'metrics/proto/chrome_user_metrics_extension.proto',

+ 'metrics/proto/histogram_event.proto',

+ 'metrics/proto/omnibox_event.proto',

+ 'metrics/proto/perf_data.proto',

+ 'metrics/proto/profiler_event.proto',

+ 'metrics/proto/system_profile.proto',

+ 'metrics/proto/user_action_event.proto',

Ilya Sherman 2014/04/15 23:00:40 The proto files should be in the proto target, not

+ 'variables': {

+ 'proto_in_dir': 'metrics/proto',

+ 'proto_out_dir': 'components/metrics/proto',

+ },

+ 'includes': [ '../build/protoc.gypi' ],

}

« chrome/browser/metrics/metrics_log.cc ('K') | « components/components_tests.gyp ('k') | components/metrics/metrics_log_base.h » ('j') | components/metrics/metrics_log_base.h » ('J')