Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: components/metrics/metrics_log_base_unittest.cc

Issue 239093004: Move part of metrics from chrome/common to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding TBR section for owners of minor changes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_log_base_unittest.cc
diff --git a/chrome/common/metrics/metrics_log_base_unittest.cc b/components/metrics/metrics_log_base_unittest.cc
similarity index 91%
rename from chrome/common/metrics/metrics_log_base_unittest.cc
rename to components/metrics/metrics_log_base_unittest.cc
index 4c77f6014872e5b82f8cf8fb8d81cc3e77e05b93..2e6e8f2fae86a7b621b1c968dc00d4be7841547f 100644
--- a/chrome/common/metrics/metrics_log_base_unittest.cc
+++ b/components/metrics/metrics_log_base_unittest.cc
@@ -2,16 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/metrics/metrics_log_base.h"
+#include "components/metrics/metrics_log_base.h"
#include <string>
#include "base/base64.h"
#include "base/metrics/bucket_ranges.h"
#include "base/metrics/sample_vector.h"
-#include "chrome/common/metrics/proto/chrome_user_metrics_extension.pb.h"
+#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
+namespace metrics {
+
namespace {
class TestMetricsLogBase : public MetricsLogBase {
@@ -57,8 +59,6 @@ TEST(MetricsLogBaseTest, EmptyRecord) {
expected.mutable_system_profile()->set_build_timestamp(
parsed.system_profile().build_timestamp());
expected.mutable_system_profile()->set_app_version("bogus version");
- expected.mutable_system_profile()->set_channel(
- parsed.system_profile().channel());
expected.mutable_system_profile()->mutable_hardware()->set_hardware_class(
"sample-class");
@@ -78,9 +78,9 @@ TEST(MetricsLogBaseTest, HistogramBucketFields) {
ranges.set_range(7, 12);
base::SampleVector samples(&ranges);
- samples.Accumulate(3, 1); // Bucket 1-5.
- samples.Accumulate(6, 1); // Bucket 5-7.
- samples.Accumulate(8, 1); // Bucket 8-9. (7-8 skipped)
+ samples.Accumulate(3, 1); // Bucket 1-5.
+ samples.Accumulate(6, 1); // Bucket 5-7.
+ samples.Accumulate(8, 1); // Bucket 8-9. (7-8 skipped)
samples.Accumulate(10, 1); // Bucket 10-11. (9-10 skipped)
samples.Accumulate(11, 1); // Bucket 11-12.
@@ -121,3 +121,5 @@ TEST(MetricsLogBaseTest, HistogramBucketFields) {
EXPECT_TRUE(histogram_proto.bucket(4).has_max());
EXPECT_EQ(12, histogram_proto.bucket(4).max());
}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698