Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2390873002: Drop unused NaCl Debugger whitelisting. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unused NaCl Debugger whitelisting. BUG=374955 R=michaelpg@chromium.org,mkwst@chromium.org Committed: https://crrev.com/8a872353e0eea9fe9e7af2877f218a14a4bbfebe Cr-Commit-Position: refs/heads/master@{#422817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
bradnelson
4 years, 2 months ago (2016-10-03 22:02:55 UTC) #1
michaelpg
lgtm (but not an owner), thanks!
4 years, 2 months ago (2016-10-03 23:15:43 UTC) #2
bradnelson
+mkwst@chromium.org Mike, OWNERS says you're only for docs, as the extensions owners is now empty, ...
4 years, 2 months ago (2016-10-04 05:37:08 UTC) #5
michaelpg
On 2016/10/04 05:37:08, bradnelson wrote: > mailto:+mkwst@chromium.org > > Mike, OWNERS says you're only for ...
4 years, 2 months ago (2016-10-04 05:45:00 UTC) #7
bradnelson
mkwst was what git cl owners suggests, but probably just because it's not able to ...
4 years, 2 months ago (2016-10-04 06:07:46 UTC) #8
bradnelson
Oh, misread, I see, there is the link to src/extensions/OWNERS. Devlin, can you please review? ...
4 years, 2 months ago (2016-10-04 06:08:44 UTC) #9
Devlin
lgtm
4 years, 2 months ago (2016-10-04 15:04:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390873002/1
4 years, 2 months ago (2016-10-04 15:18:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:03:39 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:06:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a872353e0eea9fe9e7af2877f218a14a4bbfebe
Cr-Commit-Position: refs/heads/master@{#422817}

Powered by Google App Engine
This is Rietveld 408576698