Chromium Code Reviews| Index: tools/perf/measurements/page_cycler.py |
| diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py |
| index b7dffbc461c223fda18aeae8f1b6eb032e1a1c3b..e7803a41844d985872dfb74f5525e09f3dd3b53b 100644 |
| --- a/tools/perf/measurements/page_cycler.py |
| +++ b/tools/perf/measurements/page_cycler.py |
| @@ -81,15 +81,11 @@ class PageCycler(page_measurement.PageMeasurement): |
| tab.ClearCache(force=True) |
| if self._report_speed_index: |
| self._speedindex_metric.Start(page, tab) |
| + self._cpu_metric.Start(page, tab) |
| def DidNavigateToPage(self, page, tab): |
| self._memory_metric.Start(page, tab) |
| self._power_metric.Start(page, tab) |
| - # TODO(qyearsley): Uncomment the following line and move it to |
| - # WillNavigateToPage once the cpu metric has been changed. |
| - # This is being temporarily commented out to let the page cycler |
| - # results return to how they were before the cpu metric was added. |
| - # self._cpu_metric.Start(page, tab) See crbug.com/301714. |
|
bulach
2014/04/17 17:42:10
never mind this file, I'll split into a separate p
tonyg
2014/04/18 03:58:56
Yes, separate patch sg
bulach
2014/04/22 12:43:10
split into https://codereview.chromium.org/2464530
|
| if self._record_v8_object_stats: |
| self._v8_object_stats_metric.Start(page, tab) |
| @@ -144,8 +140,8 @@ class PageCycler(page_measurement.PageMeasurement): |
| # TODO(qyearsley): Uncomment the following line when CPU metric is |
| # changed. See crbug.com/301714. |
| - # self._cpu_metric.Stop(page, tab) |
| - # self._cpu_metric.AddResults(tab, results) |
| + self._cpu_metric.Stop(page, tab) |
| + self._cpu_metric.AddResults(tab, results) |
| if self._record_v8_object_stats: |
| self._v8_object_stats_metric.Stop(page, tab) |
| self._v8_object_stats_metric.AddResults(tab, results) |