Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: content/browser/gpu/compositor_util.cc

Issue 239083006: Change ACCELERATED_COMPOSITING blacklist to GPU_COMPOSITING. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blacklistaccel: tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/gpu/gpu_feature_browsertest.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/compositor_util.cc
diff --git a/content/browser/gpu/compositor_util.cc b/content/browser/gpu/compositor_util.cc
index 0d82711debb5833ead837fe7202efdef49793fe6..e5d655327098cc746bbffa5dd8ca50a6d308ac0f 100644
--- a/content/browser/gpu/compositor_util.cc
+++ b/content/browser/gpu/compositor_util.cc
@@ -41,19 +41,17 @@ const GpuFeatureInfo GetGpuFeatureInfo(size_t index, bool* eof) {
true
},
{
- "compositing",
+ "gpu_compositing",
manager->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING),
+ gpu::GPU_FEATURE_TYPE_GPU_COMPOSITING),
false,
- "Accelerated compositing has been disabled, either via about:flags or"
- " command line. This adversely affects performance of all hardware"
- " accelerated features.",
+ "Gpu compositing has been disabled, either via about:flags or"
+ " command line. The browser will fall back to software compositing"
+ " and hardware acceleration will be unavailable.",
true
},
{
"3d_css",
- manager->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING) ||
manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_3D_CSS),
command_line.HasSwitch(switches::kDisableAcceleratedLayers),
"Accelerated layers have been disabled at the command line.",
@@ -61,8 +59,6 @@ const GpuFeatureInfo GetGpuFeatureInfo(size_t index, bool* eof) {
},
{
"css_animation",
- manager->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING) ||
manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_3D_CSS),
command_line.HasSwitch(cc::switches::kDisableThreadedAnimation) ||
command_line.HasSwitch(switches::kDisableAcceleratedLayers),
@@ -168,9 +164,7 @@ bool CanDoAcceleratedCompositing() {
// Don't use force compositing mode if gpu access has been blocked or
// accelerated compositing is blacklisted.
- if (!manager->GpuAccessAllowed(NULL) ||
- manager->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING))
+ if (!manager->GpuAccessAllowed(NULL))
return false;
// Check for SwiftShader.
@@ -330,8 +324,7 @@ base::Value* GetFeatureStatus() {
} else {
status = "enabled";
if (gpu_feature_info.name == "webgl" &&
- (manager->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING)))
+ manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_GPU_COMPOSITING))
status += "_readback";
bool has_thread = IsThreadedCompositingEnabled();
if (gpu_feature_info.name == "compositing") {
« no previous file with comments | « chrome/test/gpu/gpu_feature_browsertest.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698